From owner-freebsd-current@FreeBSD.ORG Thu Aug 18 22:42:44 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 32C7216A420 for ; Thu, 18 Aug 2005 22:42:44 +0000 (GMT) (envelope-from oberman@es.net) Received: from postal2.es.net (postal2.es.net [198.128.3.206]) by mx1.FreeBSD.org (Postfix) with ESMTP id E71B943D48 for ; Thu, 18 Aug 2005 22:42:43 +0000 (GMT) (envelope-from oberman@es.net) Received: from ptavv.es.net ([198.128.4.29]) by postal2.es.net (Postal Node 2) with ESMTP (SSL) id IBA74465; Thu, 18 Aug 2005 15:42:42 -0700 Received: from ptavv (localhost [127.0.0.1]) by ptavv.es.net (Tachyon Server) with ESMTP id B49B75D08; Thu, 18 Aug 2005 15:42:41 -0700 (PDT) To: Phil Oleson In-reply-to: Your message of "Thu, 18 Aug 2005 15:16:30 MDT." <4304FAAE.4090109@nixil.net> Date: Thu, 18 Aug 2005 15:42:41 -0700 From: "Kevin Oberman" Message-Id: <20050818224241.B49B75D08@ptavv.es.net> Cc: Stefan Farfeleder , current@freebsd.org Subject: Re: Unable to build libedit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2005 22:42:44 -0000 > Date: Thu, 18 Aug 2005 15:16:30 -0600 > From: Phil Oleson > Sender: owner-freebsd-current@freebsd.org > > Stefan Farfeleder wrote: > > On Thu, Aug 18, 2005 at 01:00:48PM -0600, Phil Oleson wrote: > > > >>Personally, I'm still unsure why we have histedit.h pre-installed in > >>src/include. This might be showing my ignorance of some of the build > >>mechanisms in the main src tree, but wouldn't this work out better if > >>histedit.h was located in src/lib/libedit until install time? > > > > > > I guess the reason for putting most headers into src/include is that it > > prevents dozens of -I paths while building. > > > > Stefan > > well, I was looking at the Makefile in src/lib/libedit and it only uses > 'CFLAGS+= -I. -I${.CURDIR}', So in the upgrade case it wouldn't find > the histedit.h in /usr/obj/usr/src/tmp/usr/include. Though now that I > think about it, I can see where the -I paths for other base system apps > that use libedit would suffer (sh,tftp,fsdb,cdcontrol,lpr-lpc). I think > an additional -I needs to be added to the libedit Makefile, something > like -I${WORLDTMP}/usr/include ?? I don't think so. buildworld is supposed to build the system using the files in the /usr/obj directory. That's why the /usr/obj/usr/src/tmp/ structure is there. I don't see explicit references to it in other Makefiles. All of the header files built in the 'includes' pass should be there and be used in lieu of the standard system header files during the 'all' pass of buildworld. Of course, if they are not there, I guess that the /usr/include files will be used, but 'histedit.h IS there. Still lost in a maze of twisty little .mk files, all different. -- R. Kevin Oberman, Network Engineer Energy Sciences Network (ESnet) Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab) E-mail: oberman@es.net Phone: +1 510 486-8634