Date: Thu, 18 Aug 2005 15:42:41 -0700 From: "Kevin Oberman" <oberman@es.net> To: Phil Oleson <oz@nixil.net> Cc: Stefan Farfeleder <stefan@fafoe.narf.at>, current@freebsd.org Subject: Re: Unable to build libedit Message-ID: <20050818224241.B49B75D08@ptavv.es.net> In-Reply-To: Your message of "Thu, 18 Aug 2005 15:16:30 MDT." <4304FAAE.4090109@nixil.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> Date: Thu, 18 Aug 2005 15:16:30 -0600
> From: Phil Oleson <oz@nixil.net>
> Sender: owner-freebsd-current@freebsd.org
>
> Stefan Farfeleder wrote:
> > On Thu, Aug 18, 2005 at 01:00:48PM -0600, Phil Oleson wrote:
> >
> >>Personally, I'm still unsure why we have histedit.h pre-installed in
> >>src/include. This might be showing my ignorance of some of the build
> >>mechanisms in the main src tree, but wouldn't this work out better if
> >>histedit.h was located in src/lib/libedit until install time?
> >
> >
> > I guess the reason for putting most headers into src/include is that it
> > prevents dozens of -I paths while building.
> >
> > Stefan
>
> well, I was looking at the Makefile in src/lib/libedit and it only uses
> 'CFLAGS+= -I. -I${.CURDIR}', So in the upgrade case it wouldn't find
> the histedit.h in /usr/obj/usr/src/tmp/usr/include. Though now that I
> think about it, I can see where the -I paths for other base system apps
> that use libedit would suffer (sh,tftp,fsdb,cdcontrol,lpr-lpc). I think
> an additional -I needs to be added to the libedit Makefile, something
> like -I${WORLDTMP}/usr/include ??
I don't think so. buildworld is supposed to build the system using the
files in the /usr/obj directory. That's why the /usr/obj/usr/src/tmp/
structure is there. I don't see explicit references to it in other
Makefiles. All of the header files built in the 'includes' pass should
be there and be used in lieu of the standard system header files during
the 'all' pass of buildworld. Of course, if they are not there, I guess
that the /usr/include files will be used, but 'histedit.h IS there.
Still lost in a maze of twisty little .mk files, all different.
--
R. Kevin Oberman, Network Engineer
Energy Sciences Network (ESnet)
Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab)
E-mail: oberman@es.net Phone: +1 510 486-8634
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050818224241.B49B75D08>