From owner-cvs-src@FreeBSD.ORG Fri Sep 8 20:34:52 2006 Return-Path: <owner-cvs-src@FreeBSD.ORG> X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3612E16A412; Fri, 8 Sep 2006 20:34:52 +0000 (UTC) (envelope-from marcus@freebsd.org) Received: from av-tac-rtp.cisco.com (hen.cisco.com [64.102.19.198]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19B1043D72; Fri, 8 Sep 2006 20:34:49 +0000 (GMT) (envelope-from marcus@freebsd.org) X-TACSUNS: Virus Scanned Received: from rooster.cisco.com (localhost [127.0.0.1]) by av-tac-rtp.cisco.com (8.11.7p1+Sun/8.11.7) with ESMTP id k88KYnf23628; Fri, 8 Sep 2006 16:34:49 -0400 (EDT) Received: from [10.1.1.73] (jclarke-vpn.cisco.com [172.18.173.17]) by rooster.cisco.com (8.11.7p1+Sun/8.11.7) with ESMTP id k88KYlB02568; Fri, 8 Sep 2006 16:34:48 -0400 (EDT) Message-ID: <4501D3E6.20906@freebsd.org> Date: Fri, 08 Sep 2006 16:34:46 -0400 From: Joe Marcus Clarke <marcus@freebsd.org> Organization: FreeBSD, Inc. User-Agent: Thunderbird 1.5.0.5 (Macintosh/20060719) MIME-Version: 1.0 To: Jung-uk Kim <jkim@freebsd.org> References: <200609081459.k88ExtSR084500@repoman.freebsd.org> <200609081309.29850.jkim@FreeBSD.org> <20060908172232.GG14781@deviant.kiev.zoral.com.ua> <200609081414.27800.jkim@FreeBSD.org> In-Reply-To: <200609081414.27800.jkim@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Kostik Belousov <kostikbel@gmail.com>, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/libexec/rtld-elf rtld.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/cvs-src> List-Post: <mailto:cvs-src@freebsd.org> List-Help: <mailto:cvs-src-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 08 Sep 2006 20:34:52 -0000 Jung-uk Kim wrote: > On Friday 08 September 2006 01:22 pm, Kostik Belousov wrote: >> On Fri, Sep 08, 2006 at 01:09:24PM -0400, Jung-uk Kim wrote: >>> On Friday 08 September 2006 10:59 am, Konstantin Belousov wrote: >>>> kib 2006-09-08 14:59:55 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> libexec/rtld-elf rtld.c >>>> Log: >>>> When looking up the symbol by dlsym, look it not only in the >>>> object given as dso handle, but also in the implicit >>>> dependencies of that dso. >>>> >>>> Also, const-ify the read-only parameter objlist of >>>> symlook_list. >>>> >>>> Reported by: "Simon 'corecode' Schubert" <corecode at fs >>>> ei tum de> Approved by: kan (mentor) >>>> X-MFC-After: 6.2 >>>> >>>> Revision Changes Path >>>> 1.117 +10 -13 src/libexec/rtld-elf/rtld.c >>> I believe this warrants version number change for ports, IMO. >> This change brings rtld behaviour to the standard. Solaris and >> Linux both do this in the right way. Shall we bump >> __FreeBSD_version for such kind of bugfixes ? >> >> BTW, are you aware of ports that rely on old behaviour ? > > OpenOffice.org has been long time victim of this issue. > > http://www.openoffice.org/issues/show_bug.cgi?id=22253 > > The most recent one is: > > http://www.openoffice.org/issues/show_bug.cgi?id=66667 Mozilla is also a "victim." So are GTK+ and gnome-vfs, for that matter. This is a very welcome fix. Joe -- Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome