From owner-p4-projects@FreeBSD.ORG Wed Jul 12 10:26:38 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 3339D16A4E5; Wed, 12 Jul 2006 10:26:38 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D4EF16A4DA for ; Wed, 12 Jul 2006 10:26:38 +0000 (UTC) (envelope-from piso@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9DB943D9C for ; Wed, 12 Jul 2006 10:26:29 +0000 (GMT) (envelope-from piso@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6CAQTMW014500 for ; Wed, 12 Jul 2006 10:26:29 GMT (envelope-from piso@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6CAQTdF014497 for perforce@freebsd.org; Wed, 12 Jul 2006 10:26:29 GMT (envelope-from piso@freebsd.org) Date: Wed, 12 Jul 2006 10:26:29 GMT Message-Id: <200607121026.k6CAQTdF014497@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to piso@freebsd.org using -f From: Paolo Pisati To: Perforce Change Reviews Cc: Subject: PERFORCE change 101347 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jul 2006 10:26:38 -0000 http://perforce.freebsd.org/chv.cgi?CH=101347 Change 101347 by piso@piso_newluxor on 2006/07/12 10:25:54 Slightly updates MD code to correcly use filters and place a comment about interrupts EOIing & masking that was not updated (and should be consequently checked). Affected files ... .. //depot/projects/soc2006/intr_filter/arm/arm/intr.c#4 edit .. //depot/projects/soc2006/intr_filter/ia64/ia64/interrupt.c#5 edit .. //depot/projects/soc2006/intr_filter/powerpc/powerpc/intr_machdep.c#5 edit .. //depot/projects/soc2006/intr_filter/sparc64/sparc64/intr_machdep.c#5 edit Differences ... ==== //depot/projects/soc2006/intr_filter/arm/arm/intr.c#4 (text+ko) ==== @@ -116,8 +116,9 @@ /* Execute fast handlers. */ thread = intr_filter_loop(event, frame); + // XXX eoi & mask intr not verified. /* Schedule thread if needed. */ - if (thread) + if (thread & FILTER_SCHEDULE_THREAD) intr_event_schedule_thread(event); else arm_unmask_irq(i); ==== //depot/projects/soc2006/intr_filter/ia64/ia64/interrupt.c#5 (text+ko) ==== @@ -383,7 +383,8 @@ thread = intr_filter_loop(ie, NULL); critical_exit(); - if (thread) { + // XXX eoi & mask intr not verified. + if (thread & FILTER_SCHEDULE_THREAD) { error = intr_event_schedule_thread(ie); KASSERT(error == 0, ("got an impossible stray interrupt")); } else ==== //depot/projects/soc2006/intr_filter/powerpc/powerpc/intr_machdep.c#5 (text+ko) ==== @@ -239,8 +239,9 @@ thread = intr_filter_loop(ie, NULL); critical_exit(); + // XXX eoi & mask intr not verified. /* Schedule a heavyweight interrupt process. */ - if (thread) + if (thread & FILTER_SCHEDULE_THREAD) error = intr_event_schedule_thread(ie); if (error == EINVAL) ==== //depot/projects/soc2006/intr_filter/sparc64/sparc64/intr_machdep.c#5 (text+ko) ==== @@ -247,8 +247,9 @@ /* Execute fast interrupt handlers directly. */ thread = intr_filter_loop(ie, NULL); + // XXX eoi & mask intr not verified. /* Schedule a heavyweight interrupt process. */ - if (thread) + if (thread & FILTER_SCHEDULE_THREAD) error = intr_event_schedule_thread(ie); if (error == EINVAL)