From owner-freebsd-ports@FreeBSD.ORG Thu Nov 6 12:44:16 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 679FB16A4D3 for ; Thu, 6 Nov 2003 12:44:16 -0800 (PST) Received: from mgr2.xmission.com (mgr2.xmission.com [198.60.22.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3945543FEA for ; Thu, 6 Nov 2003 12:44:15 -0800 (PST) (envelope-from glewis@eyesbeyond.com) Received: from [198.60.22.206] (helo=mgr6.xmission.com) by mgr2.xmission.com with esmtp (Exim 3.35 #1) id 1AHqzG-0003ZN-02 for ports@freebsd.org; Thu, 06 Nov 2003 13:44:14 -0700 Received: from mail by mgr6.xmission.com with spam-scanned (Exim 3.35 #1) id 1AHqzG-0000QM-06 for ports@freebsd.org; Thu, 06 Nov 2003 13:44:14 -0700 Received: from [207.135.128.145] (helo=misty.eyesbeyond.com) by mgr6.xmission.com with esmtp (Exim 3.35 #1) id 1AHqM1-0005Yt-06; Thu, 06 Nov 2003 13:03:41 -0700 Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) by misty.eyesbeyond.com (8.12.10/8.12.9) with ESMTP id hA6K5q1K046602; Thu, 6 Nov 2003 13:05:52 -0700 (MST) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.12.10/8.12.9/Submit) id hA6K5nYk046601; Thu, 6 Nov 2003 13:05:49 -0700 (MST) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Thu, 6 Nov 2003 13:05:49 -0700 From: Greg Lewis To: Stefan Walter Message-ID: <20031106200549.GA46441@misty.eyesbeyond.com> References: <20031105102325.GA5600@kyuzo.dunkelkammer.void> <20031105182705.GA6342@misty.eyesbeyond.com> <20031106165317.GA15763@kyuzo.dunkelkammer.void> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031106165317.GA15763@kyuzo.dunkelkammer.void> User-Agent: Mutt/1.4.1i X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on mgr6.xmission.com X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.60 X-Spam-Level: cc: ports@freebsd.org Subject: Re: Rotting PRs reminder X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2003 20:44:16 -0000 On Thu, Nov 06, 2003 at 05:53:17PM +0100, Stefan Walter wrote: > Greg Lewis, 05.11.03, 19:27h CET: > > On Wed, Nov 05, 2003 at 11:23:25AM +0100, Stefan Walter wrote: > > > these two PRs for new ports have been around for almost four months > > > without even a single comment: > > > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/54335 > > > (PPower4 - Post processor for PDF presentations made with (La)TeX) > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/54372 > > > (FoilTeX - a collection of LaTeX files for making foils/slides) > > > > > > If there's anything wrong with them, it's unlikely for me to notice > > > unless someone points it out to me - they do work for me without any > > > problems. > > > > Looking at them briefly... > > Thanks, your comments made me look up a few things I should have known > earlier. > > > The FoilTeX do-extract looks suspiciously like it should be a build > > target rather than an extract. > > In a way, the process also looks like an extraction to me, but I don't > mind; it's a do-build now. Thanks! > > Both ports look like you could use %%EXAMPLESDIR%% and %%DOCSDIR%% in > > the packing list. > > Did that, plus a few more of those. > > > Why is mktexlsr not just run during post-install instead of printing > > a message saying one should do so? > > You're right, I changed that, too. It still has to be done manually when > installing via pkg_add, though, so I kept the message. Why not create a pkg-install script to do it? That will be run during pkg_add. Something simple like this should do it: #!/bin/sh if [ "$2" = "POST-INSTALL" ]; then ${LOCALBASE}/bin/mktexlsr fi If you wanted to avoid duplication, you could then call this script from the Makefile's post-install target instead of doing an explicit mktexlsr, e.g. post-install: ${SETENV} LOCALBASE=${LOCALBASE} ${SH} ${PKGDIR}/pkg-install ${PKGNAME} POST-INSTALL > > The PPower4 port should install its JAR in JAVAJARDIR, as defined by > > bsd.java.mk. > > It now does. I didn't know about that one. > > The new shar files are attached to the PRs now. Great. I think they are almost ready to commit :). Let me know if you're going to make the pkg-install change and I will commit the ports when you are done. -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org