From owner-svn-src-head@FreeBSD.ORG Wed Jun 13 11:19:04 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7FB21106564A; Wed, 13 Jun 2012 11:19:04 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id 677828FC14; Wed, 13 Jun 2012 11:19:03 +0000 (UTC) Received: by eabm6 with SMTP id m6so173553eab.13 for ; Wed, 13 Jun 2012 04:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=bViCmpw7E8fPxgBYrMvUGzIhER/rcewjdezLcqMiZ88=; b=m24qE/OHy6HXq8/GUDurTg2uavSzjGlidHdgvNRYivt3p+rj5Q0hx/lCo4XfQl7mo4 jHzB2l2w93Zfb5eDWreySsA+0ePmQQPsJU5Kpm6SS1AehExDF+NI9UBXDwr5uZIVaq/Y Innyo4P3Qk4Tt9mr2sP/ouOGQRMmsTa5erUbrX3dbpnkMhJYssnaTrZ9FTEf+c7bjDT8 3vSRLrTW/dOKFQZcwVCs0xVsd0Y9QKopZ/k4GU3wJahR+VW8Iv0N+zL3X9MbK1BJ+ob2 6sRSj6FE+06ZNx/VXiInFO4AZcLsieQm3lAWGeGGuWZv3Ic+qdOHFpU7yu3BfH3g0HOM PecA== Received: by 10.14.28.133 with SMTP id g5mr1255796eea.168.1339586342188; Wed, 13 Jun 2012 04:19:02 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPS id x52sm6343316eea.11.2012.06.13.04.19.00 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 13 Jun 2012 04:19:01 -0700 (PDT) Date: Wed, 13 Jun 2012 13:18:53 +0200 From: Mateusz Guzik To: Pawel Jakub Dawidek Message-ID: <20120613111853.GC3893@dft-labs.eu> References: <20120612104749.GB20749@dft-labs.eu> <20120612114335.GA1372@garage.freebsd.pl> <20120612134950.GC20749@dft-labs.eu> <20120612160128.GA1429@garage.freebsd.pl> <20120612191828.GD20749@dft-labs.eu> <20120612214400.GB1429@garage.freebsd.pl> <20120613093807.GA3893@dft-labs.eu> <20120613102900.GD1386@garage.freebsd.pl> <20120613105344.GB3893@dft-labs.eu> <20120613111309.GE1386@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20120613111309.GE1386@garage.freebsd.pl> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, davidxu@FreeBSD.org Subject: Re: svn commit: r236935 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2012 11:19:04 -0000 On Wed, Jun 13, 2012 at 01:13:09PM +0200, Pawel Jakub Dawidek wrote: > On Wed, Jun 13, 2012 at 12:53:44PM +0200, Mateusz Guzik wrote: > > http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free5.patch > > > > David reported that previous version of the patch fixed panic he was > > experiencing, so I consider the patch tested. > > Looks good, one (hopefully last) minor nit. I'd change this comment: > > * Search the bitmap for a free descriptor starting at minfd. If none > * is found, try to grow the file table. > > To something like this: > > * Search the bitmap for a free descriptor starting at minfd. > * If none is found, grow the file table. > > 'try' is a bit misleading for my taste, as it suggest that growing the > file table might fail, I think. > Done in: http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free6.patch > That's all from me:) > Thanks for your comments and suggestions. -- Mateusz Guzik