From owner-freebsd-hackers  Wed Apr 16 04:28:54 1997
Return-Path: <owner-hackers>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id EAA20460
          for hackers-outgoing; Wed, 16 Apr 1997 04:28:54 -0700 (PDT)
Received: from widefw.csl.sony.co.jp (widefw.csl.sony.co.jp [133.138.1.1])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id EAA20455
          for <freebsd-hackers@FreeBSD.ORG>; Wed, 16 Apr 1997 04:28:50 -0700 (PDT)
Received: from hotaka.csl.sony.co.jp (hotaka.csl.sony.co.jp [43.27.98.57]) by widefw.csl.sony.co.jp (8.8.3/3.5Wbeta) with ESMTP id LAA05877; Wed, 16 Apr 1997 11:28:36 GMT
Received: from localhost (localhost [127.0.0.1]) by hotaka.csl.sony.co.jp (8.8.4/3.3W3) with ESMTP id UAA21402; Wed, 16 Apr 1997 20:28:19 +0900 (JST)
Message-Id: <199704161128.UAA21402@hotaka.csl.sony.co.jp>
To: rsvp-test@ISI.EDU
Cc: freebsd-hackers@FreeBSD.ORG, arl@arl.wustl.edu
Subject: Re: ALTQ/CBQ alpha release 
In-reply-to: Your message of "Thu, 27 Mar 1997 22:23:11 JST."
             <199703271323.WAA06023@hotaka.csl.sony.co.jp> 
Date: Wed, 16 Apr 1997 20:28:18 +0900
From: Kenjiro Cho <kjc@csl.sony.co.jp>
Sender: owner-hackers@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


>> I am pleased to announce the first public alpha release of ALTQ/CBQ.
>> ALTQ is an alternate queueing framework for BSD Unix, currently built
>> on FreeBSD-2.2.1R.
>> We have ported SUN/UCL/LBL-CBQ onto this framework, which can be used
>> as a traffic control kernel for RSVP.

Quite a few people downloaded the release but a bug is found in the
RSVP stub in the release.  It turned out that rsvpd is not able to
create CBQ classes for reservations because of the initialization
order problem.

If you are using ALTQ/CBQ with RSVP, please apply the patch attached
below to "cbq-rsvp/tc_cbq.c" (symbolic linked to "cbq-tools/rsvp_cbq.c")
and re-make rsvpd.

The release version number reflected this fix moved to 0.2.1.

---
Kenjiro Cho
Sony Computer Science Laboratory Inc.

------------------------------------------------------------------
--- ../altq-0.2/cbq-rsvp/tc_cbq.c	Thu Mar 27 20:38:06 1997
+++ tc_cbq.c	Tue Apr 15 14:37:09 1997
@@ -171,6 +171,12 @@
 	if(cbq_init()) {
 		log(LOG_WARNING, 0, "Can't initialize CBQ.  Continuing without scheduling support\n", 0);
 	}
+
+#if !defined(sun)
+        for (i = 0; i < if_num; i++) 
+	        tc_clear(i);
+#endif
+
 	/* Initialize RSVP */
 	if (rsvp_config()) {
 		log(LOG_ERR, 0, 
@@ -179,16 +185,14 @@
 		exit(-1);
 	}
 
+#if defined(sun)
         /* clear old reservations from the kernel and then make a
 	 *	reservation for RSVP packets, on each interface.
 	 */
         for (i = 0; i < if_num; i++) {
-#if !defined(sun)
-	        tc_clear(i);
-#else
                 kern_rsvpresv(i);
-#endif
         }
+#endif
 }
 
 #ifndef CBQDAEMON
@@ -922,6 +926,7 @@
 		ifinfo->cd_class = new_cl;
 		new_cl->acinfo.type = admission_type;
 #if !defined(sun)
+		new_cl->acinfo.pri = pri;
 		new_cl->acinfo.bandwidth = bandwidth;
 #else
 		new_cl->acinfo.bandwidth =
------------------------------------------------------------------