From owner-svn-src-head@freebsd.org Tue Nov 6 17:37:34 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4BC9B112B2C5; Tue, 6 Nov 2018 17:37:34 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: from mail-yw1-f45.google.com (mail-yw1-f45.google.com [209.85.161.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7D1A682C43; Tue, 6 Nov 2018 17:37:33 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: by mail-yw1-f45.google.com with SMTP id c126-v6so5467204ywd.8; Tue, 06 Nov 2018 09:37:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u/4c51+jqIZa+FA3Fmwq6u6KlmxexTLXHkQaziylwhM=; b=ZnsqI89hJOfGbKBh2VYOz6oyG5Bi9UnHlUu92C65hOW1JqV8snVTxlJlX+eivXc7nG rSZMXnFk4E4SJZJS47RWgj/Kg5ribJb4n5My3+4MfnFhbVBZj+G2gFbiMVsIxozIYlyJ NtoQYQBXt31VMm7XP1a66IREUfHY/6ODU9TdqTSl57/62gFmKnINef4a8ciiRunMMK4u eeRD5FmQ3jKYWaDHl2+6eP25/aEyULq82GHEi8xBj38GFAnuUxJbTh2dPxlyrEEVDePX c5julP4eVfRcRIDBZ1vVwr2qjwdgh5Ka2OReWsRIptDGyq/h4/AwU3v87bK7lUVb/a+Z w6aQ== X-Gm-Message-State: AGRZ1gIhE/ZQN58ofGoYum86QH3G7wWN7Kuo3LKA+u0ogtZst3wdlXC6 bREA6x0ZJKlnVZFQgEz2cm7eQIUsu2sUew== X-Google-Smtp-Source: AJdET5eBYUIbMIMaBL44+UWH0DIiVbgIJsBP7lkZ589kee49Y6ye2bowv+SzmQXjxQ6IPNb8lbgtOA== X-Received: by 2002:a81:592:: with SMTP id 140-v6mr26290922ywf.378.1541525846890; Tue, 06 Nov 2018 09:37:26 -0800 (PST) Received: from mail-yw1-f50.google.com (mail-yw1-f50.google.com. [209.85.161.50]) by smtp.gmail.com with ESMTPSA id s187-v6sm12541727ywe.10.2018.11.06.09.37.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 09:37:26 -0800 (PST) Received: by mail-yw1-f50.google.com with SMTP id k6-v6so5465160ywa.11; Tue, 06 Nov 2018 09:37:26 -0800 (PST) X-Received: by 2002:a81:30ca:: with SMTP id w193-v6mr25795388yww.506.1541525846038; Tue, 06 Nov 2018 09:37:26 -0800 (PST) MIME-Version: 1.0 References: <201810230631.w9N6VPR4008554@repo.freebsd.org> <9612d267-91dc-b1ee-7530-284376f08f08@FreeBSD.org> In-Reply-To: From: Alexander Richardson Date: Tue, 6 Nov 2018 17:37:14 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r339636 - in head: . share/mk To: Markiyan Kushnir Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-Rspamd-Queue-Id: 7D1A682C43 X-Spamd-Result: default: False [-3.00 / 200.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RWL_MAILSPIKE_GOOD(0.00)[45.161.85.209.rep.mailspike.net : 127.0.0.18]; URI_COUNT_ODD(1.00)[15]; RCVD_COUNT_THREE(0.00)[4]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; FORGED_SENDER(0.30)[arichardson@freebsd.org,arichardsonkde@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; IP_SCORE(-1.01)[ipnet: 209.85.128.0/17(-3.57), asn: 15169(-1.39), country: US(-0.08)]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.993,0]; FROM_NEQ_ENVFROM(0.00)[arichardson@freebsd.org,arichardsonkde@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-0.998,0]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[45.161.85.209.list.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 17:37:34 -0000 Hi Markiyan, This looks exactly like the SYSTEM_COMPILER/SYSTEM_LINKER build failure that should have been fixed by r340167. Does passing BUILD_WITH_STRICT_TMPPATH=3D0 on the make command line fix the build error? If so it seems like I missed one more SYSTEM_COMPILER case. Could you send me your buildworld command+environment variables so I can see what's going wrong? Thanks, Alex On Tue, 6 Nov 2018 at 17:12 Markiyan Kushnir wrote: > Alexander, > > Cannot tell exactly what change it was, might be one of your recent > changes to bsd.compiler.mk or Makefile.inc1? ... > > Now running "make buildworld" I can proceed with "3.1: recording build > metadata" only having USING_SYSTEM_COMPILER=3Dyes USING_SYSTEM_LINKER=3Dy= es set > in my environment. Otherwise I'm getting this: > > sh: cc: not found > make[2]: "/work/src.svn/share/mk/bsd.compiler.mk" line 176: Unable to > determine compiler type for CC=3Dcc -target x86_64-unknown-freebsd13.0 > --sysroot=3D//usr/obj/work/src.svn/amd64.amd64/tmp > -B//usr/obj/work/src.svn/amd64.amd64/tmp/usr/bin. Consider setting > COMPILER_TYPE. > *** Error code 1 > > Stop. > make[1]: stopped in /work/src.svn > *** Error code 1 > > Stop. > make: stopped in /work/src.svn > Failed to build world > > I'm at rev. 340189. Could you please have a look? > > -- > Markiyan > > =D0=B2=D1=82, 6 =D0=BB=D0=B8=D1=81=D1=82. 2018 =D0=BE 01:11 Alexander Ric= hardson > =D0=BF=D0=B8=D1=88=D0=B5: > >> On Mon, 5 Nov 2018 at 23:00, Bryan Drewery wrote: >> > >> > On 10/22/2018 11:31 PM, Alex Richardson wrote: >> > > Author: arichardson >> > > Date: Tue Oct 23 06:31:25 2018 >> > > New Revision: 339636 >> > > URL: https://svnweb.freebsd.org/changeset/base/339636 >> > > >> > > Log: >> > > Only compute the X_COMPILER_*/X_LINKER_* variables when needed >> > > >> > > When building CheriBSD we have to set XLD/XCC/XCFLAGS on the >> command line. >> > > This triggers the $XCC !=3D $CC case in bsd.compiler.mk (and the >> same for LD >> > > in bsd.linker.mk) which causes it to call ${XCC} --version and >> > > ${XLD} --version (plus various awk+sed+echo calls) in every >> subdirectory. >> > > For incremental builds and stages that only walk the source tree >> this is >> > > often the majority of the time spent in that directory. >> > > >> > ... >> > >> > > By only computing the value of the X_COMPILER_*/X_LINKER_* >> variables if >> > > _WANT_TOOLCHAIN_CROSS_VARS is set we can reduce the number of cc/l= d >> calls >> > > to once per build stage instead of once per recursive make. >> > >> > This sounds wrong. bsd.compiler.mk *already* handles that kind of thin= g >> > by exporting its computations. Adding a second hack for a similar >> > problem isn't the right solution. >> > >> >> I added debug .info statements for every time bsd.compiler.mk was >> running cc --version and it was always running it for $XCC during make >> buildworld. >> As far as I can tell this happens because $CC and $XCC no longer match. >> I believe the problem is that the toplevel makefile runs the cross >> stages with CC=3D"${XCC} ${XCFLAGS}" so if you have XCFLAGS set in your >> environment $CC will never be equal to $XCC. >> This also means there is not cached variable for $XCC since it was >> computed for "${XCC} ${XCFLAGS}" rather than $XCC . >> >> This patch massively reduced the incremental build time for CheriBSD >> but if you can suggest I better fix that would be great. >> >> Alex >> > _______________________________________________ >> svn-src-all@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-all >> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >> >