From owner-cvs-all Tue Sep 4 10:14:30 2001 Delivered-To: cvs-all@freebsd.org Received: from earth.backplane.com (earth-nat-cw.backplane.com [208.161.114.67]) by hub.freebsd.org (Postfix) with ESMTP id 8513437B405; Tue, 4 Sep 2001 10:14:25 -0700 (PDT) Received: (from dillon@localhost) by earth.backplane.com (8.11.6/8.11.2) id f84HEPQ92719; Tue, 4 Sep 2001 10:14:25 -0700 (PDT) (envelope-from dillon) Date: Tue, 4 Sep 2001 10:14:25 -0700 (PDT) From: Matt Dillon Message-Id: <200109041714.f84HEPQ92719@earth.backplane.com> To: John Baldwin Cc: Peter Wemm , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_shutdown.c References: Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :> John Baldwin wrote: :>> :>> On 02-Sep-01 Peter Wemm wrote: :>> > peter 2001/09/02 05:24:38 PDT :>> > :>> > Modified files: :>> > sys/kern kern_shutdown.c :>> > Log: :>> > The !RESTARTABLE_PANICS code has some loose ends. :>> :>> What is holding_giant for? Oh, and you do know that you are truly evil :>> incarnate now, right? :> :> I'm not sure. Matt added it in rev 1.107, but the code that sets it is :>#if 0'ed out. It is a real mess. Please feel free to undo the holding_giant junk. The issue is that in at least one place Giant is obtained solely in order to call panic(). If panic() returns there, Giant is left held because the calling code does not know panic might return, and will panic the machine again later. Of course, panic isn't really restartable in a large number of situations so I think the holding_giant stuff should just be removed entirely. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message