Date: Wed, 7 Nov 2007 21:09:59 GMT From: Stephen Hurd <shurd@sasktel.net> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/117897: [PATCH] net-im/amsn configure script broken Message-ID: <200711072109.lA7L9x5c083585@www.freebsd.org> Resent-Message-ID: <200711072120.lA7LK1N4068870@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 117897
>Category: ports
>Synopsis: [PATCH] net-im/amsn configure script broken
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Nov 07 21:20:01 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator: Stephen Hurd
>Release: 6.2-RELEASE-p6
>Organization:
>Environment:
FreeBSD server.hurd.local 6.2-RELEASE-p6 FreeBSD 6.2-RELEASE-p6 #3: Tue Jul 24 22:03:03 PDT 2007 root@server.hurd.local:/usr/src/sys/i386/compile/SERVER i386
>Description:
The configure script in net-im/amsn uses gtest-isms, tclsh, doesn't pass additional include paths to cc -E for header tests, and overrides command-line parameters in favour of ones from /usr/local/lib/tk8.4/tkConfig.sh.
>How-To-Repeat:
Attempt to build net-im/amsn
>Fix:
Add the attached file to the files directory.
Patch attached with submission follows:
--- configure.orig Wed Nov 1 09:05:49 2006
+++ configure Wed Nov 7 13:03:49 2007
@@ -1334,7 +1334,7 @@
fi;
-if test "$enable_debug" == "yes" ; then
+if test "$enable_debug" = "yes" ; then
DEBUG="yes"
else
DEBUG="no"
@@ -1347,7 +1347,7 @@
fi;
-if test "$enable_static" == "yes" ; then
+if test "$enable_static" = "yes" ; then
STATIC="yes"
else
STATIC="no"
@@ -1472,7 +1472,7 @@
fi
-TCLSH=`which tclsh`
+TCLSH=`which tclsh8.4`
VERSION=`echo "puts $::tcl_version ; exit" | ${TCLSH}`
# Check whether --enable-version-check or --disable-version-check was given.
if test "${enable_version_check+set}" = set; then
@@ -1484,7 +1484,7 @@
OLDV=`expr $VERSION \< 8.4`
-if test "x${version_ok}" == "xyes" -a $OLDV == 1; then
+if test "x${version_ok}" = "xyes" -a "$OLDV" = "1"; then
{ { echo "$as_me:$LINENO: error: Your current Tcl/Tk installation has a version number of $VERSION. The minimal version required for aMSN to run is Tcl/Tk 8.4" >&5
echo "$as_me: error: Your current Tcl/Tk installation has a version number of $VERSION. The minimal version required for aMSN to run is Tcl/Tk 8.4" >&2;}
{ (exit 1); exit 1; }; }
@@ -2425,7 +2425,7 @@
CC_INSTALLED=`which $CC`
-if test "x${CC_INSTALLED}" == "x"; then
+if test "x${CC_INSTALLED}" = "x"; then
{ { echo "$as_me:$LINENO: error: You need a C compiler (gcc) to compiler aMSN. Please install gcc and try again" >&5
echo "$as_me: error: You need a C compiler (gcc) to compiler aMSN. Please install gcc and try again" >&2;}
{ (exit 1); exit 1; }; }
@@ -2788,7 +2788,7 @@
CXX_INSTALLED=`which $CXX`
-if test "x${CXX_INSTALLED}" == "x"; then
+if test "x${CXX_INSTALLED}" = "x"; then
{ { echo "$as_me:$LINENO: error: You need a C++ compiler (g++) to compiler aMSN. Please install g++ and try again" >&5
echo "$as_me: error: You need a C++ compiler (g++) to compiler aMSN. Please install g++ and try again" >&2;}
{ (exit 1); exit 1; }; }
@@ -2864,10 +2864,9 @@
if test "x${version_ok}" != "xyes"; then
VERSION=${TCL_VERSION}
fi
-
if test "x${TCL_INC_DIR}" != "x" -o "x${TCL_INC_SPEC}" != "x" \
-o "x${TCL_INCLUDE_DIR}" != "x" -o "x${TCL_INCLUDE_SPEC}" != "x"; then
- if test "x${TCL_VERSION}" == "x${VERSION}" ; then
+ if test "x${TCL_VERSION}" = "x${VERSION}" ; then
TCL_LIB_DIR=`cd $i; pwd`
break;
fi
@@ -2924,15 +2923,15 @@
TCL_INC_DIR=$TCL_INCLUDE_SPEC
fi
- if test "x${TCL_INC_DIR}" == "x"; then
+ if test "x${TCL_INC_DIR}" = "x"; then
TCL_INC_DIR=$TCL_INCLUDE_DIR
fi
- if test "x${TCL_INC_DIR}" == "x" -a -f ${TCL_PREFIX}/include/tcl.h; then
+ if test "x${TCL_INC_DIR}" = "x" -a -f ${TCL_PREFIX}/include/tcl.h; then
TCL_INC_DIR=${TCL_PREFIX}/include
fi
- if test "x${TCL_INC_DIR}" == "x"; then
+ if test "x${TCL_INC_DIR}" = "x"; then
{ { echo "$as_me:$LINENO: error: You dot not have a devel package of Tcl" >&5
echo "$as_me: error: You dot not have a devel package of Tcl" >&2;}
{ (exit 1); exit 1; }; }
@@ -2946,7 +2945,7 @@
TCL_INC_SPEC=$TCL_INC_DIR
framework=`echo "${TCL_BASE}" | grep -- "-framework"`
- if test "x${framework}" == "x"; then
+ if test "x${framework}" = "x"; then
TCL_LIB_SPEC="-L${TCL_LIB_DIR} -l${TCL_BASE}"
fi
TCL_STUB_LIB_SPEC="-L${TCL_LIB_DIR} -l${TCL_STUB_BASE}"
@@ -3016,7 +3015,7 @@
if test "x${TK_INC_DIR}" != "x" -o "x${TK_INC_SPEC}" != "x" \
-o "x${TK_INCLUDE_DIR}" != "x" -o "x${TK_INCLUDE_SPEC}" != "x"; then
- if test "x${TK_VERSION}" == "x${VERSION}"; then
+ if test "x${TK_VERSION}" = "x${VERSION}"; then
TK_LIB_DIR=`cd $i; pwd`
break;
fi
@@ -3060,19 +3059,19 @@
TK_INC_DIR=$TK_INC_SPEC
fi
- if test "x${TK_INCLUDE_SPEC}" != "x"; then
- TK_INC_DIR=$TK_INCLUDE_SPEC
- fi
+ #if test "x${TK_INCLUDE_SPEC}" != "x"; then
+ #TK_INC_DIR=$TK_INCLUDE_SPEC
+ #fi
- if test "x${TK_INC_DIR}" == "x"; then
+ if test "x${TK_INC_DIR}" = "x"; then
TK_INC_DIR=$TK_INCLUDE_DIR
fi
- if test "x${TK_INC_DIR}" == "x" -a -f ${TK_PREFIX}/include/tk.h; then
+ if test "x${TK_INC_DIR}" = "x" -a -f ${TK_PREFIX}/include/tk.h; then
TK_INC_DIR=${TK_PREFIX}/include
fi
- if test "x${TK_INC_DIR}" == "x"; then
+ if test "x${TK_INC_DIR}" = "x"; then
{ { echo "$as_me:$LINENO: error: You dot not have a devel package of Tk" >&5
echo "$as_me: error: You dot not have a devel package of Tk" >&2;}
{ (exit 1); exit 1; }; }
@@ -3186,7 +3185,7 @@
echo $ECHO_N "(cached) $ECHO_C" >&6
else
# Double quotes because CPP needs to be expanded
- for CPP in "$CC -E" "$CC -E -traditional-cpp" "/lib/cpp"
+ for CPP in "$CC -E $CFLAGS $CPPFLAGS" "$CC -E -traditional-cpp" "/lib/cpp"
do
ac_preproc_ok=false
for ac_c_preproc_warn_flag in '' yes
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200711072109.lA7L9x5c083585>