From owner-p4-projects@FreeBSD.ORG  Tue Aug 15 14:17:36 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 1EAAE16A4DF; Tue, 15 Aug 2006 14:17:36 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D890016A4DD
	for <perforce@FreeBSD.org>; Tue, 15 Aug 2006 14:17:35 +0000 (UTC)
	(envelope-from rdivacky@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A342543D45
	for <perforce@FreeBSD.org>; Tue, 15 Aug 2006 14:17:35 +0000 (GMT)
	(envelope-from rdivacky@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k7FEHZiK096313
	for <perforce@FreeBSD.org>; Tue, 15 Aug 2006 14:17:35 GMT
	(envelope-from rdivacky@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k7FEHZAj096310
	for perforce@freebsd.org; Tue, 15 Aug 2006 14:17:35 GMT
	(envelope-from rdivacky@FreeBSD.org)
Date: Tue, 15 Aug 2006 14:17:35 GMT
Message-Id: <200608151417.k7FEHZAj096310@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	rdivacky@FreeBSD.org using -f
From: Roman Divacky <rdivacky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 104030 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Aug 2006 14:17:36 -0000

http://perforce.freebsd.org/chv.cgi?CH=104030

Change 104030 by rdivacky@rdivacky_witten on 2006/08/15 14:16:35

	Remove the crit section in futex_atomic_op(). The operations should be atomic
	itself and using crit section blows up in a case of page fault.
	
	Pointed out by: jhb

Affected files ...

.. //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_futex.c#25 edit

Differences ...

==== //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_futex.c#25 (text+ko) ====

@@ -448,8 +448,6 @@
 #endif
 	/* XXX: linux verifies access here and returns EFAULT */
 
-	critical_enter();
-
 	switch (op) {
 	   	case FUTEX_OP_SET:
 		   	ret = futex_xchgl(oparg, uaddr, &oldval);
@@ -470,8 +468,6 @@
 			ret = -ENOSYS;
 	}
 
-	critical_exit();
-
 	if (!ret)
 	   	switch (cmp) {
 		      case FUTEX_OP_CMP_EQ: