From owner-cvs-all@FreeBSD.ORG  Mon Apr  5 11:17:04 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4B4C916A4CE; Mon,  5 Apr 2004 11:17:04 -0700 (PDT)
Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 31B4343D31; Mon,  5 Apr 2004 11:17:03 -0700 (PDT)
	(envelope-from ru@ip.net.ua)
Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213])
	by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i35IKuIB049995
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 5 Apr 2004 21:20:57 +0300 (EEST)
	(envelope-from ru@ip.net.ua)
Received: (from ru@localhost)
	by heffalump.ip.net.ua (8.12.11/8.12.11) id i35IGrid001240;
	Mon, 5 Apr 2004 21:16:53 +0300 (EEST)
	(envelope-from ru)
Date: Mon, 5 Apr 2004 21:16:53 +0300
From: Ruslan Ermilov <ru@freebsd.org>
To: Robert Watson <rwatson@freebsd.org>
Message-ID: <20040405181653.GA1212@ip.net.ua>
References: <20040331072756.GA14337@ip.net.ua>
	<Pine.NEB.3.96L.1040331090544.4625B-100000@fledge.watson.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="VS++wcV0S1rZb1Fb"
Content-Disposition: inline
In-Reply-To: <Pine.NEB.3.96L.1040331090544.4625B-100000@fledge.watson.org>
User-Agent: Mutt/1.5.6i
X-Virus-Scanned: by amavisd-new
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)
cc: Brooks Davis <brooks@one-eyed-alien.net>
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/net if_gif.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 18:17:04 -0000


--VS++wcV0S1rZb1Fb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 31, 2004 at 09:06:56AM -0500, Robert Watson wrote:
>=20
> On Wed, 31 Mar 2004, Ruslan Ermilov wrote:
>=20
> > > > Implemented this in the attached patch.  Note when testing: setting
> > > > net.link.gif.max_nesting too high (>20 on my system) and triggering
> > > > the recursion causes the kernel stack exhaustion.
> > >=20
> > > Why not just do what OpenBSD does and do actual loop detection?  This
> > > gets rid of the nesting count hack which isn't really what you want to
> > > measure anyway.
> > >=20
> > > http://www.openbsd.org/cgi-bin/cvsweb/src/sys/net/if_gif.c.diff?r1=3D=
1.18&r2=3D1.19
> > >=20
> > Good idea.  I will implement it and repost the updated patch here.
>=20
> While you're at it, we also need loop detection in if_gre.  Make sure to
> check the IP- and IPv6-layer pieces of these as well.
>=20
Um, what do you mean, should I _check_ by running, or what?


Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer

--VS++wcV0S1rZb1Fb
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAcaKVUkv4P6juNwoRAl2EAJkBihQsgZL9doQumrMW1QZqyGBvtQCff+0C
hyYsktlx/OMtyqBvvk7bzTg=
=yr9C
-----END PGP SIGNATURE-----

--VS++wcV0S1rZb1Fb--