From owner-svn-src-head@FreeBSD.ORG Thu Dec 15 09:35:03 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D5939106564A; Thu, 15 Dec 2011 09:35:03 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 3CDE68FC08; Thu, 15 Dec 2011 09:35:02 +0000 (UTC) Received: by vbbfr13 with SMTP id fr13so2210718vbb.13 for ; Thu, 15 Dec 2011 01:35:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=P9J1j/cdruQ8uAPIdzJ767PnP0f7sYAXZEM7aA5fRgU=; b=LRSuUiS7sdw4lo9SLJ9FQrEVslUlmSSkQj2pp8ODDNosA8W+MfXuoBQbOjyVa/v3WX ruRWzNmLyMi6f9j0FC8Gy83FbeEiAJ+BagkJX4RmVeKwJlb0/Em49xBylIblf3NsOHaL vEbUqKGQ7u2W7j93JZVExFl04Fm/fPRN27QXw= MIME-Version: 1.0 Received: by 10.52.65.129 with SMTP id x1mr2131022vds.11.1323941702422; Thu, 15 Dec 2011 01:35:02 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.52.26.50 with HTTP; Thu, 15 Dec 2011 01:35:02 -0800 (PST) In-Reply-To: References: <201112150052.pBF0qUA5022051@svn.freebsd.org> Date: Thu, 15 Dec 2011 01:35:02 -0800 X-Google-Sender-Auth: 5EuBYxwu5bOFvFJQdUELsZ5cucM Message-ID: From: Adrian Chadd To: Bernhard Schmidt Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228514 - head/sys/net80211 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Dec 2011 09:35:04 -0000 On 15 December 2011 00:02, Bernhard Schmidt wrote: > Why didn't you remove the mac argument? It is assign from wh->i_addr2 > anyways, seems rather too redundant to me. Because the semantics for that right now are "check that MAC", so it's the callers responsibility to determine which MAC in the header is the relevant one to check against. They're all addr2 though, and I haven't yet thought of a reason it could be addr1 or addr3 (or addr4, for that matter); I just decided to leave it this way so the semantics of "the caller dictates which MAC in the frame is the relevant one to check against" as-is. If you think that's me being a bit overly anal about it, then sure, please go ahead and turf it. :) Personally, I'd like to add an enum field (and then remove the MAC) - the enum field would indicate to acl_check() _which_ ACL is being checked - ie, probe request, association request, and any other frame check request. That way it's precisely clear what the ACL check is for. But again, that's just me being overly picky. :) So in short: if you're happy removing it, remove it. :) Adrian