From owner-svn-src-head@freebsd.org  Wed Jun 21 19:03:24 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B4AA3D97407;
 Wed, 21 Jun 2017 19:03:24 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 6C5E17ABE9;
 Wed, 21 Jun 2017 19:03:22 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id WAA21745;
 Wed, 21 Jun 2017 22:03:15 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1dNkuJ-000PBK-QP; Wed, 21 Jun 2017 22:03:15 +0300
Subject: Re: svn commit: r317591 - head/sys/dev/drm2/radeon
To: TAKAHASHI Yoshihiro <nyan@FreeBSD.org>
Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org,
 svn-src-head@FreeBSD.org
References: <201704290947.v3T9lF0r075921@repo.freebsd.org>
 <03e500d5-76b1-fd38-04c6-90d85a2ddfa8@FreeBSD.org>
 <20170611.000714.2063715294250192258.nyan@FreeBSD.org>
From: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <61cac4d7-0710-1f5e-8268-42b441b3b6ba@FreeBSD.org>
Date: Wed, 21 Jun 2017 22:02:19 +0300
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170611.000714.2063715294250192258.nyan@FreeBSD.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Jun 2017 19:03:24 -0000

On 10/06/2017 18:07, TAKAHASHI Yoshihiro wrote:
> In article <03e500d5-76b1-fd38-04c6-90d85a2ddfa8@FreeBSD.org>
> Andriy Gapon <avg@FreeBSD.org> writes:
> 
>> On 29/04/2017 12:47, Takahashi Yoshihiro wrote:
>>> Author: nyan
>>> Date: Sat Apr 29 09:47:15 2017
>>> New Revision: 317591
>>> URL: https://svnweb.freebsd.org/changeset/base/317591
>>>
>>> Log:
>>>   Add TUNABLE_INT to radeonkms driver parameters.
>>>   They are required by PowerMac G5 DP.
>>>   
>>>   PR:		217852
>>>   Submitted by:	Hiroo Ono
>>>   MFC after:	1 week
>>
>> I think that this solution that I had in my private tree is a little bit more
>> powerful:
>> https://people.freebsd.org/~avg/radeon_drv-knobs.diff
>>
>> The advantage is that it is less intrusive and also provides read-only sysctl in
>> addition to the tunables.
>> Also, hw.drm.radeon seems like a better place for the knobs than just drm.radeon.
>>
>> Do you mind if I commit this?
> 
> Sorry for late.
> 
> I don't mind that your suggestion.  But if you will commit the patch,
> I think that you should apply the same way to the i915 driver.

Ooh, I didn't realize that there was a precedent and that "drm" was already used
as a root for tunables.  So, not sure if I want to pursue this further...

Thank you!


-- 
Andriy Gapon