From owner-cvs-src@FreeBSD.ORG Thu Apr 3 11:00:00 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5714937B401; Thu, 3 Apr 2003 11:00:00 -0800 (PST) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 839EF43FA3; Thu, 3 Apr 2003 10:59:56 -0800 (PST) (envelope-from ru@whale.sunbay.crimea.ua) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h33Ixqgg021224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 3 Apr 2003 21:59:52 +0300 (EEST) (envelope-from ru@whale.sunbay.crimea.ua) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h33Ixg3Q021207; Thu, 3 Apr 2003 21:59:42 +0300 (EEST) (envelope-from ru) Date: Thu, 3 Apr 2003 21:59:42 +0300 From: Ruslan Ermilov To: "David O'Brien" Message-ID: <20030403185942.GA20191@sunbay.com> References: <200304030513.h335DR60079544@repoman.freebsd.org> <20030402231638.A81523@FreeBSD.org> <20030403055049.GA67232@dhcp01.pn.xcllnt.net> <20030403180026.A29934@gamplex.bde.org> <20030403085350.GA37174@sunbay.com> <20030403155917.GC17860@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/9DWx/yDrRhgMJTb" Content-Disposition: inline In-Reply-To: <20030403155917.GC17860@dragon.nuxi.com> User-Agent: Mutt/1.5.4i cc: src-committers@FreeBSD.org cc: Bruce Evans cc: Juli Mallett cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/libexec/talkd announce.c extern.h print.c table.c talkd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Apr 2003 19:00:01 -0000 --/9DWx/yDrRhgMJTb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 03, 2003 at 07:59:17AM -0800, David O'Brien wrote: > On Thu, Apr 03, 2003 at 11:53:50AM +0300, Ruslan Ermilov wrote: > > -. if ${WARNS} > 4 > > +. if ${WARNS} > 4 && !empty(CFLAGS:M-O*) && empty(CFLAGS:M-O0) > > CFLAGS +=3D -Wuninitialized > > . endif >=20 > Why not just get rid of it totally? We have this already: >=20 > . if ${WARNS} > 1 && ${WARNS} < 5 > # XXX Delete -Wuninitialized by default for now -- the compiler doesn= 't > # XXX always get it right. > CFLAGS +=3D -Wno-uninitialized > . endif >=20 > so we already know it is problematic. OR rather than use: >=20 > . if ${WARNS} > 4=20 > CFLAGS +=3D -Wuninitialized > . endif >=20 > use >=20 > . if ${WARNS} =3D=3D 4=20 > CFLAGS +=3D -Wuninitialized > . endif >=20 -Wuninitialized may be fixed at some point, but it will still be unsupported without -O. Why would we remove the support for it if we can handle it right? I find the -Wuninitialized very useful, it saved me lot of crashes. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --/9DWx/yDrRhgMJTb Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+jISeUkv4P6juNwoRAk9zAJ9gphtIBUy9mOaa20ZmqhYZW+JJVQCeMnVl ceS5EvWOKcf4X9pED51zfkE= =8ydh -----END PGP SIGNATURE----- --/9DWx/yDrRhgMJTb--