From owner-cvs-src@FreeBSD.ORG Sat Jul 23 15:08:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3CB0716A420; Sat, 23 Jul 2005 15:08:54 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A0DD43D53; Sat, 23 Jul 2005 15:08:54 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j6NF8rF8019347; Sat, 23 Jul 2005 15:08:53 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j6NF8rMo019346; Sat, 23 Jul 2005 15:08:53 GMT (envelope-from rwatson) Message-Id: <200507231508.j6NF8rMo019346@repoman.freebsd.org> From: Robert Watson Date: Sat, 23 Jul 2005 15:08:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jul 2005 15:08:54 -0000 rwatson 2005-07-23 15:08:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/vm uma_core.c Log: Merge uma_core.c:1.125 from HEAD to RELENG_5: Move the unlocking of the zone mutex in sysctl_vm_zone_stats() so that it covers the following of the uc_alloc/freebucket cache pointers. Originally, I felt that the race wasn't helped by holding the mutex, hence a comment in the code and not holding it across the cache access. However, it does improve consistency, as while it doesn't prevent bucket exchange, it does prevent bucket pointer invalidation. So a race in gathering cache free space statistics still can occur, but not one that follows an invalid bucket pointer, if the mutex is held. Submitted by: yongari Approved by: re (kensmith) Revision Changes Path 1.119.2.6 +9 -5 src/sys/vm/uma_core.c