From owner-freebsd-bugs@FreeBSD.ORG Wed Aug 20 14:10:01 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 234BB106568D for ; Wed, 20 Aug 2008 14:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EF34E8FC3D for ; Wed, 20 Aug 2008 14:10:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m7KEA0ak052342 for ; Wed, 20 Aug 2008 14:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m7KEA0cf052341; Wed, 20 Aug 2008 14:10:00 GMT (envelope-from gnats) Resent-Date: Wed, 20 Aug 2008 14:10:00 GMT Resent-Message-Id: <200808201410.m7KEA0cf052341@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Derek Tattersall Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 59C0E1065675 for ; Wed, 20 Aug 2008 14:05:11 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 43B898FC0A for ; Wed, 20 Aug 2008 14:05:11 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m7KE5AWv026475 for ; Wed, 20 Aug 2008 14:05:10 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m7KE5Ak3026473; Wed, 20 Aug 2008 14:05:10 GMT (envelope-from nobody) Message-Id: <200808201405.m7KE5Ak3026473@www.freebsd.org> Date: Wed, 20 Aug 2008 14:05:10 GMT From: Derek Tattersall To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/126682: Sed segfaults on error rather than error message X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Aug 2008 14:10:01 -0000 >Number: 126682 >Category: misc >Synopsis: Sed segfaults on error rather than error message >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Aug 20 14:10:00 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Derek Tattersall >Release: 8.0 CURRENT >Organization: >Environment: FreeBSD oriental.arm.org 8.0-CURRENT FreeBSD 8.0-CURRENT #16: Sun Aug 17 11:41:53 EDT 2008 root@oriental.arm.org:/usr/obj/usr/src/sys/ORIENTAL amd64 >Description: echo test | sed 's/test/\1/' segfaults rather than issuing a message regarding the nonexistence of what "\1" refers to. >How-To-Repeat: echo test | sed 's/test/\1/' >Fix: Patch attached with submission follows: diff -u /usr/src/usr.bin/sed/compile.c ./compile.c --- /usr/src/usr.bin/sed/compile.c 2008-02-09 04:12:02.000000000 -0500 +++ ./compile.c 2008-08-20 09:47:27.000000000 -0400 @@ -324,13 +324,13 @@ if (p == NULL) errx(1, "%lu: %s: unterminated substitute pattern", linenum, fname); - --p; - p = compile_subst(p, cmd->u.s); - p = compile_flags(p, cmd->u.s); if (*re == '\0') cmd->u.s->re = NULL; else cmd->u.s->re = compile_re(re, cmd->u.s->icase); + --p; + p = compile_subst(p, cmd->u.s); + p = compile_flags(p, cmd->u.s); EATSPACE(); if (*p == ';') { p++; >Release-Note: >Audit-Trail: >Unformatted: