From owner-svn-src-head@FreeBSD.ORG Sat Apr 4 00:26:01 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AB0AC1065673; Sat, 4 Apr 2009 00:26:01 +0000 (UTC) (envelope-from nwhitehorn@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 7F7F18FC1F; Sat, 4 Apr 2009 00:26:01 +0000 (UTC) (envelope-from nwhitehorn@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n340Q14W039518; Sat, 4 Apr 2009 00:26:01 GMT (envelope-from nwhitehorn@svn.freebsd.org) Received: (from nwhitehorn@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n340Q14E039517; Sat, 4 Apr 2009 00:26:01 GMT (envelope-from nwhitehorn@svn.freebsd.org) Message-Id: <200904040026.n340Q14E039517@svn.freebsd.org> From: Nathan Whitehorn Date: Sat, 4 Apr 2009 00:26:01 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r190682 - head/sys/dev/ata/chipsets X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Apr 2009 00:26:02 -0000 Author: nwhitehorn Date: Sat Apr 4 00:26:01 2009 New Revision: 190682 URL: http://svn.freebsd.org/changeset/base/190682 Log: The Serverworks SATA chipsets used in Apple G5 systems require requiring the ATA status register with a 4-byte read request. This updates it, and subsequent 1-byte reads will return the correct result. This commit adds a hack to do this, which is currently ifdef'd powerpc, although Linux and Darwin do this unconditionally on all platforms. Modified: head/sys/dev/ata/chipsets/ata-serverworks.c Modified: head/sys/dev/ata/chipsets/ata-serverworks.c ============================================================================== --- head/sys/dev/ata/chipsets/ata-serverworks.c Sat Apr 4 00:22:44 2009 (r190681) +++ head/sys/dev/ata/chipsets/ata-serverworks.c Sat Apr 4 00:26:01 2009 (r190682) @@ -58,6 +58,9 @@ static int ata_serverworks_ch_detach(dev static void ata_serverworks_tf_read(struct ata_request *request); static void ata_serverworks_tf_write(struct ata_request *request); static void ata_serverworks_setmode(device_t dev, int mode); +#ifdef __powerpc__ +static int ata_serverworks_status(device_t dev); +#endif /* misc defines */ #define SWKS_33 0 @@ -98,6 +101,23 @@ ata_serverworks_probe(device_t dev) return 0; } +#ifdef __powerpc__ +static int +ata_serverworks_status(device_t dev) +{ + struct ata_channel *ch = device_get_softc(dev); + + /* + * We need to do a 4-byte read on the status reg before the values + * will report correctly + */ + + ATA_IDX_INL(ch,ATA_STATUS); + + return ata_pci_status(dev); +} +#endif + static int ata_serverworks_chipinit(device_t dev) { @@ -186,6 +206,9 @@ ata_serverworks_ch_attach(device_t dev) ata_pci_hw(dev); ch->hw.tf_read = ata_serverworks_tf_read; ch->hw.tf_write = ata_serverworks_tf_write; +#ifdef __powerpc__ + ch->hw.status = ata_serverworks_status; +#endif /* chip does not reliably do 64K DMA transfers */ ch->dma.max_iosize = 64 * DEV_BSIZE;