From nobody Wed Mar 25 01:29:55 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fgTq803zTz6WVHP for ; Wed, 25 Mar 2026 01:29:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fgTq769qCz3SDp for ; Wed, 25 Mar 2026 01:29:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774402195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y64k7zpKoKVxvBnEFmzJPjyFxBBvF8L18CSpNL1pUCE=; b=MiHdLAs6IFAIqNprkMtVn5Siac8BBYHWNAIxUuBEOiHCAbhLiZ7tZERtTRKnhbQqlleQ0D KZpf55dmcG3FpASayG3FGHjOE1F+FKT+giRTkXrip5bzlszLrFfSn11xVPGSGOOzqw7Lyr X4u6yLPu5E7W3YlaFjnjTqAXP/EPVZ9dHOUqeM3JyMMArrSy8Fy+G+kRNCbiEjTKtEPyUt 6L87qQiC7V41/pvNLwhC6jBmb9i4pN1MeJE0kmjuvJ387Il4JNXjA4JjghTlVoMHT0lnEG hkCaybtRvrO9S3kuvPgwxfsuQZvCbQslv5wDjmpiQSSvNCvLtjJ1koDHL7w6OQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774402195; a=rsa-sha256; cv=none; b=nnnRa5rcNes6d3A0iE6k5KYHqOK1zILpRBqcIyUqRGsqaCI/nhqyfoWoyWv/bO8PuFPDzT wJH5wxdIs54JaucyEBsLCbEHtKhq0eSNUdb44vkjhfb+CbgluqTBqZIqz+3S9NQkEy0WCM Ip/4o/NqR/BQPbAHSbH9UxzqumCZ+4KqXx0pCh87sgw2sySs4k2eGZdi+dsRa19kALPs/c oXPvVm8wqmXxN3n6AKvlW4rZdEhN5ca3mYprqVML8n2mP+DARIQqKSxI+IJmoMC4BwpEI0 RD7keOjmzdK0OEfniKEdSzGGlxOb6YeEosob7Vzdd1MH2lBv1WdOE5XpP0drgw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774402195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y64k7zpKoKVxvBnEFmzJPjyFxBBvF8L18CSpNL1pUCE=; b=EtA1sxaMM0Outq0a3o0upA5B/E/WEHEAn77ExILKriS4nDC3tHDom7hfSMmublMtIBZ5Xp vZY0mq8TpO9XJVpqAzp26ZFi16soQjhypqkyy67AgrztmY8TUQ3GFNsrqXxH4XPslDg3sR txuLYxllBgJF5btZAQ0HIWNdBMzZ4whQG9bD4HVDsSCw8sSa7Pa2WDWx0F0A55KNPfno1z ooJu07uT7JmoeHZhZ18lHZl/8I0sVfrUI/bTcyqdZBYkB+moDg8fYF7a/cSzD/4VHq7DD3 B2/hkZjYYdzc+gov5oBj7l0EeE/SRgb3WT3YAnwGBBXFyPM2nPX4LSreaRymJg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fgTq73ncDzkwG for ; Wed, 25 Mar 2026 01:29:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1895d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 25 Mar 2026 01:29:55 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Brad Smith From: Adrian Chadd Subject: git: f7fd4e79fa09 - main - rge: handle interface flags changes List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f7fd4e79fa0943446aa5900147f737a70c73d9e3 Auto-Submitted: auto-generated Date: Wed, 25 Mar 2026 01:29:55 +0000 Message-Id: <69c33a93.1895d.63e7c35d@gitrepo.freebsd.org> The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=f7fd4e79fa0943446aa5900147f737a70c73d9e3 commit f7fd4e79fa0943446aa5900147f737a70c73d9e3 Author: Brad Smith AuthorDate: 2026-03-25 01:22:52 +0000 Commit: Adrian Chadd CommitDate: 2026-03-25 01:22:52 +0000 rge: handle interface flags changes Handle interface flags like other drivers do. Reviewed by: zlei, adrian Differential Revision: https://reviews.freebsd.org/D55728 --- sys/dev/rge/if_rge.c | 21 ++++++++------------- sys/dev/rge/if_rgevar.h | 2 ++ 2 files changed, 10 insertions(+), 13 deletions(-) diff --git a/sys/dev/rge/if_rge.c b/sys/dev/rge/if_rge.c index e5297edfefbe..5ae0b98f95a1 100644 --- a/sys/dev/rge/if_rge.c +++ b/sys/dev/rge/if_rge.c @@ -959,29 +959,24 @@ rge_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data) case SIOCSIFFLAGS: RGE_LOCK(sc); if ((if_getflags(ifp) & IFF_UP) != 0) { - if ((if_getdrvflags(ifp) & IFF_DRV_RUNNING) == 0) { - /* - * TODO: handle promisc/iffmulti changing - * without reprogramming everything. - */ + if ((if_getdrvflags(ifp) & IFF_DRV_RUNNING) != 0) { + if (((if_getflags(ifp) ^ sc->rge_if_flags) + & (IFF_PROMISC | IFF_ALLMULTI)) != 0) + rge_iff_locked(sc); + } else rge_init_locked(sc); - } else { - /* Reinit promisc/multi just in case */ - rge_iff_locked(sc); - } } else { - if ((if_getdrvflags(ifp) & IFF_DRV_RUNNING) != 0) { + if ((if_getdrvflags(ifp) & IFF_DRV_RUNNING) != 0) rge_stop_locked(sc); - } } + sc->rge_if_flags = if_getflags(ifp); RGE_UNLOCK(sc); break; case SIOCADDMULTI: case SIOCDELMULTI: RGE_LOCK(sc); - if ((if_getflags(ifp) & IFF_DRV_RUNNING) != 0) { + if ((if_getflags(ifp) & IFF_DRV_RUNNING) != 0) rge_iff_locked(sc); - } RGE_UNLOCK(sc); break; case SIOCGIFMEDIA: diff --git a/sys/dev/rge/if_rgevar.h b/sys/dev/rge/if_rgevar.h index 6228f9ff229e..d516537e6524 100644 --- a/sys/dev/rge/if_rgevar.h +++ b/sys/dev/rge/if_rgevar.h @@ -200,6 +200,8 @@ struct rge_softc { #define RGE_IMTYPE_SIM 1 int sc_watchdog; + int rge_if_flags; + uint32_t sc_debug; struct rge_drv_stats sc_drv_stats;