From owner-freebsd-fs Mon Feb 18 21:33:49 2002 Delivered-To: freebsd-fs@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 1507137B402 for ; Mon, 18 Feb 2002 21:33:44 -0800 (PST) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id QAA02890; Tue, 19 Feb 2002 16:33:29 +1100 Date: Tue, 19 Feb 2002 16:33:28 +1100 (EST) From: Bruce Evans X-X-Sender: To: Alfred Perlstein Cc: Subject: Re: mkdir / == odd In-Reply-To: <20020218132751.GX12136@elvis.mu.org> Message-ID: <20020219162133.D858-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-fs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Mon, 18 Feb 2002, Alfred Perlstein wrote: > # mkdir / > mkdir: /: Is a directory > > shouldn't mkdir get a EEXIST error back? Looks like I didn't fix this special case when I fixed trailing slash handling in rev.1.8 of vfs_lookup.c. > this patch to mkdir also fixes it. Um, kernel bugs can't be fixed in userland. > Index: mkdir.c > =================================================================== > RCS file: /home/ncvs/src/bin/mkdir/mkdir.c,v > retrieving revision 1.23 > diff -u -r1.23 mkdir.c > --- mkdir.c 5 Feb 2002 21:55:12 -0000 1.23 > +++ mkdir.c 18 Feb 2002 13:28:06 -0000 > @@ -143,7 +143,7 @@ > p = path; > oumask = 0; > retval = 0; > - if (p[0] == '/') /* Skip leading '/'. */ > + while (p[0] == '/') /* Skip leading '/'. */ > ++p; > for (first = 1, last = 0; !last ; ++p) { > if (p[0] == '\0') > Skipping even one slash here probably breaks mkdir(1) on systems where a leading "//" is special. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-fs" in the body of the message