Date: Mon, 23 Mar 2015 09:59:23 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r381955 - head/graphics/gdal Message-ID: <55102A4B.2060907@FreeBSD.org> In-Reply-To: <20150323143311.GC27378@ivaldir.etoilebsd.net> References: <201503222011.t2MKBHq7091087@svn.freebsd.org> <20150323015759.GA34402@FreeBSD.org> <550F8505.8010600@FreeBSD.org> <20150323135711.GB27378@ivaldir.etoilebsd.net> <5510220D.3030505@FreeBSD.org> <20150323143311.GC27378@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lPsoTiiLLnpqnH5KrStX05i84BJN3eoea Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/23/2015 9:33 AM, Baptiste Daroussin wrote: > On Mon, Mar 23, 2015 at 09:24:13AM -0500, Bryan Drewery wrote: >> On 3/23/2015 8:57 AM, Baptiste Daroussin wrote: >>> On Sun, Mar 22, 2015 at 10:14:13PM -0500, Bryan Drewery wrote: >>>> On 3/22/2015 8:58 PM, Alexey Dokuchaev wrote: >>>>> On Sun, Mar 22, 2015 at 08:11:17PM +0000, Sunpoet Po-Chuan Hsieh wr= ote: >>>>>> New Revision: 381955 >>>>>> URL: https://svnweb.freebsd.org/changeset/ports/381955 >>>>>> QAT: https://qat.redports.org/buildarchive/r381955/ >>>>>> >>>>>> Log: >>>>>> - Use -lpthread instead of -pthread >>>>> >>>>> Is -pthread going away anytime soon? I'm a bit worried of more ali= ke >>>>> changing one to another; since they're identical right now on FreeB= SD, >>>>> I'd rather reduce amount of patching, leaving whatever is picked by= >>>>> upstream, unless -lpthread really should be preferred over -pthread= >>>>> for some reason I'm unaware of (and ready to learn about). >>>>> >>>>> ./danfe >>>>> >>>> >>>> It's a pointless change. Tijl explains here >>>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D198116#c4 >>>> >>> >>> This is not pointless at all this is a long standing thing that shoul= d be >>> cleaned out for a while, portmgr already gave long ago some blanket t= o some >>> developers to remove that along with all usage of PTHREAD_LIBS. The r= eason is >>> that it is confusing for maintainers, as if they take example on some= of our >>> existing ports they might be driven in the wrong direction. >>> >>> Working in cleaning up those is imho important >>> >>> Regards, >>> Bapt >>> >> >> Reading the responses from David and Tijl I'm still at a loss at how >> this is useful. From my understanding, and what David said, -pthread i= s >> more portable. Reading documentation available from simple searching >> leads me, as a naive developer, to use -pthread. Especially when looki= ng >> for Linux documentation. Using either is the same as the other on >> FreeBSD as well. So why the major change? >> >> Removing PTHREAD_LIBS makes sense since it is a needless variable >> leftover from a more complicated past. But why change -pthread to >> -lpthread? Why not -lthr since -lpthread is actually an alias to that?= >=20 > The goal is not to change anything but remove our gratuicious changes a= nd > patches. >=20 > Meaning I am not ok with s/pthread/lpthread/ but I'm ok with removing a= ll > PTHREAD_LIBS macros in ports and all patches we do use to replace lpthr= ead with > something else >=20 > Bapt >=20 Perfect. Thank you for clarifying your stance. I thought perhaps that was what it was. --=20 Regards, Bryan Drewery --lPsoTiiLLnpqnH5KrStX05i84BJN3eoea Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVECpLAAoJEDXXcbtuRpfPGQ4H/2ESBlORTfSObX9yP+MxkcW3 9nbPXGVs8Uv+cuVnC0XM671+t8eOU2lIA27sm2iCBLcRoGg1h+5ZiosTbmIS/bNQ i+4TE9wKmpbeyv1YNfuWCWbJWhsGBaSDwte7+VkxyM/N02H4XetKT+FSXS71uGnB ObpFDXdohLNFC91Qvl7IJGdmxPKTUpB1pQvI7IU5QJlzKkXhdMOtq4Ho58wcWeMB qQdXUor/RO3QLAexFyV9zYpdsnstFeRRD006BYNuIvkP/3z85fgGGDiMf/h8ltJr ltpeRam5Y/N/oKlB5Kx156cz3/LRxeZxjdhmEL6qgdvuYiv8KBbx2CshG3JgNsQ= =Xp35 -----END PGP SIGNATURE----- --lPsoTiiLLnpqnH5KrStX05i84BJN3eoea--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55102A4B.2060907>