From owner-cvs-all@FreeBSD.ORG Mon Jan 10 22:12:02 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E019616A4CE for ; Mon, 10 Jan 2005 22:12:02 +0000 (GMT) Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by mx1.FreeBSD.org (Postfix) with ESMTP id DBA0643D54 for ; Mon, 10 Jan 2005 22:12:01 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 4537 invoked from network); 10 Jan 2005 22:12:01 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail6.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 10 Jan 2005 22:12:01 -0000 Received: from hydrogen.funkthat.com (wdixgp@localhost.funkthat.com [127.0.0.1])j0AMC0GH058970; Mon, 10 Jan 2005 14:12:00 -0800 (PST) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id j0AMC0T3058969; Mon, 10 Jan 2005 14:12:00 -0800 (PST) Date: Mon, 10 Jan 2005 14:12:00 -0800 From: John-Mark Gurney To: Scott Long Message-ID: <20050110221200.GF19624@funkthat.com> References: <200501061745.j06Hj344034786@repoman.freebsd.org> <20050110184139.GE19624@funkthat.com> <20050110202344.GC777@zaphod.nitro.dk> <41E2E561.9000504@freebsd.org> <20050110205654.GF777@zaphod.nitro.dk> <41E2F4C6.1010000@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41E2F4C6.1010000@freebsd.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Maksim Yevmenkin cc: cvs-all@freebsd.org cc: "Simon L. Nielsen" Subject: Re: cvs commit: src/sys/netgraph ng_base.c src/sys/sys kernel.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jan 2005 22:12:03 -0000 Scott Long wrote this message on Mon, Jan 10, 2005 at 14:33 -0700: > Simon L. Nielsen wrote: > > >On 2005.01.10 13:28:17 -0700, Scott Long wrote: > > > >>Simon L. Nielsen wrote: > >> > >> > >>>@@ -69,3 +69,7 @@ > >>>.An -nosplit > >>>This manual page was written by > >>>.An Alexander Langer Aq alex@FreeBSD.org . > >>>+.Sh BUGS > >>>+.Nm > >>>+only marks which modules are required for the module to work, it does > >>>+not influence start-up ordering. > >> > >>It also is used by the loader and by kldload to load the dependent > >>modules. So it's more than just an informational tag, it actually does > >>get used by the system. > > > > > >I don't think the above says it's only informational, but I'm sure the > >wording could be improved. Perhpaps somebody has a suggestion for > >better describing the issue? > > > > Well, I guess my point is that it's important to document exactly what > MODULE_DEPEND does do, and well as what it doesn't do. It's not really > a bug that it doesn't change SI_ORDER order, it's just a not a feature > that it was ever intended to support. A second paragraph under > DESCRIPTION that talks about this would probably be most appropriate. > Something like: > > .Nm > provides hints to the kernel > .Xr loader 8 > and to > .Xr kldload 8 > to ensure that the named dependency is loaded prior to the existing > module. It does not change or dictate the order in which modules are > initialized at runtime. This looks good, though it doesn't hint to kldload, since it will be the kernel linker than does dependancy loading (look at linker_load_dependencies in kern_linker.c)... it definately should NOT be in a BUGS section as it was never intended to influence startup order... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."