From owner-cvs-all@FreeBSD.ORG Tue Jan 23 18:42:05 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2A8FB16A40A for ; Tue, 23 Jan 2007 18:42:05 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id E863313C480 for ; Tue, 23 Jan 2007 18:42:04 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 72786 invoked from network); 23 Jan 2007 18:42:04 -0000 Received: from ppp-71-139-39-138.dsl.snfc21.pacbell.net (HELO ?10.0.5.59?) (nate-mail@71.139.39.138) by root.org with ESMTPA; 23 Jan 2007 18:42:04 -0000 Message-ID: <45B656F2.9010501@root.org> Date: Tue, 23 Jan 2007 10:41:54 -0800 From: Nate Lawson User-Agent: Thunderbird 1.5.0.9 (Windows/20061207) MIME-Version: 1.0 To: "M. Warner Losh" References: <45B5AE3B.6010005@root.org> <20070123.012823.1341031192.imp@bsdimp.com> <45B6410B.2090107@root.org> <20070123.102738.1244031887.imp@bsdimp.com> In-Reply-To: <20070123.102738.1244031887.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jan 2007 18:42:05 -0000 M. Warner Losh wrote: > In message: <45B6410B.2090107@root.org> > Nate Lawson writes: > : M. Warner Losh wrote: > : > In message: <45B5AE3B.6010005@root.org> > : > Nate Lawson writes: > : > : Warner Losh wrote: > : > : > imp 2007-01-22 04:34:03 UTC > : > : > > : > : > FreeBSD src repository > : > : > > : > : > Modified files: > : > : > sys/cam/scsi scsi_da.c > : > : > Log: > : > : > Add quirk for EasyMP3 EM732X usb 2.0 flash mp3 player. > : > : > (It appears that the quirk proceedures link has disappeared and that > : > : > this PR complied with it, if there's a problem, please contact me). > : > : > > : > : > PR: usb/96546 > : > : > > : > : > Revision Changes Path > : > : > 1.201 +8 -0 src/sys/cam/scsi/scsi_da.c > : > : > > : > : > > : > : > Index: src/sys/cam/scsi/scsi_da.c > : > : > diff -u src/sys/cam/scsi/scsi_da.c:1.200 src/sys/cam/scsi/scsi_da.c:1.201 > : > : > --- src/sys/cam/scsi/scsi_da.c:1.200 Tue Dec 5 07:45:28 2006 > : > : > +++ src/sys/cam/scsi/scsi_da.c Mon Jan 22 04:34:03 2007 > : > : > @@ -466,6 +466,14 @@ > : > : > {T_DIRECT, SIP_MEDIA_REMOVABLE, "X-Micro", "Flash Disk", > : > : > "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE > : > : > }, > : > : > + { > : > : > + /* > : > : > + * EasyMP3 EM732X USB 2.0 Flash MP3 Player > : > : > + * PR: usb/96546 > : > : > + */ > : > : > + {T_DIRECT, SIP_MEDIA_REMOVABLE, "*", "MP3 Player*", > : > : > + "1.0"}, /*quirks*/ DA_Q_NO_SYNC_CACHE > : > : > + }, > : > : > }; > : > : > > : > : > static disk_strategy_t dastrategy; > : > : > : > : Um, this matches every device that has "MP3 Player" somewhere in it. > : > : Are you sure it doesn't have a vendor string? > : > > : > See the PR for details and suggest something better. > : > > : > Warner > : > : According to the submitter: > : pass0: Removable Direct Access SCSI-0 device > : > : So the vendor string should be set to "EM732X" and retested. Blank > : ("*") vendor or device strings should not be committed. > > Any chance you could get your quirks how-to listed in scsi_da back > online? > > Warner I don't understand. It's been at the same location for years: http://www.root.org/~nate/freebsd/scsi/quirks.html -- Nate