From owner-svn-src-head@freebsd.org Wed Apr 11 13:48:27 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FB9CF95EEE; Wed, 11 Apr 2018 13:48:27 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E6EFC79106; Wed, 11 Apr 2018 13:48:26 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io0-x22c.google.com with SMTP id y128so2414799iod.4; Wed, 11 Apr 2018 06:48:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mJuLtrgm1lAAZIhTL23pumvb5yVDEjH38a9NnYXGRbM=; b=I4mknSM13MoribB2T9YEEz2vwpzyu4Bk7AkYY4g2btdtblo0lS7shdbbEw844b4KgY NHzpZKQlOTzyTU5BuOiYREymD+oMk97KzEMYeKZgifdEQgIrAy9kaNKJKqPkoYtwHcjj TZn2cCEfGyF2FE0g1tw8dKHMahD7el2GJ04qvxtMztxBgvlmt2K/JzRPiDp8HPcTAw8O OuXQkxaGcg5h2bkQWFxI9vAUdYgh0LIgLVEBK2hAu16zCfvKomPOjtGzzlJxSBUbjTg0 Fy6wNf411ELePzfVE9SF43sNXxIa3Az2lRewujDEPrvNzLHtiI0riN7fdQd4YqBplQjy NW/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=mJuLtrgm1lAAZIhTL23pumvb5yVDEjH38a9NnYXGRbM=; b=Y1fgvMlVXbKi2aKoWvibKB6+cuTrJWMcKVDxw8Fp9n469kPvrfAxRbhl+vTZmgvHYB 3kAZmZX8kvpgHND1wYBRrVcYCBRiVDFEGx9+qkCaxYy3zfmnByTLukQKRDJCF7vdz9XE GT9I2OLoD31Wh6AjMlBi6kkK52e3iegDiPcAoClBqmpN2H7nUbvy20QK/A/QjD6woE4o W4rky4+QC/Wwdzgse69dWPOJmhfqGbFnx7HFd7A+L/2yzTgswsdvpX67IDaDj6xGEPbA 2mMbQcPQyiJLNY/5+48wWpqNbXJYRHGograJkDcDmTlt16S7+/1ZkH5+XKRirjSTsUgQ /KGQ== X-Gm-Message-State: ALQs6tC0IuwyxydJhOnRCoz8UhiSHeaL2rJfVKt3IF153hm/N9ii9I2R bAjgHOdhIMNcc4pl8VcYgxbrRg== X-Google-Smtp-Source: AIpwx4+fIvgstrJwPwBNrM+ByHOcpi2VZGq5MsCqi8eqvOsWj0hXYZW035KQc4KIlBN2SnyV9h6WAQ== X-Received: by 10.107.137.158 with SMTP id t30mr4619027ioi.230.1523454506131; Wed, 11 Apr 2018 06:48:26 -0700 (PDT) Received: from raichu (toroon0560w-lp130-04-184-145-252-74.dsl.bell.ca. [184.145.252.74]) by smtp.gmail.com with ESMTPSA id 72-v6sm708735itg.36.2018.04.11.06.48.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Apr 2018 06:48:25 -0700 (PDT) Sender: Mark Johnston Date: Wed, 11 Apr 2018 09:48:20 -0400 From: Mark Johnston To: Allan Jude Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332365 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <20180411134820.GA43015@raichu> References: <201804101356.w3ADu6Jr072766@repo.freebsd.org> <33ea9236-2442-10d6-95d0-9e4d33c4613e@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33ea9236-2442-10d6-95d0-9e4d33c4613e@freebsd.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 13:48:27 -0000 On Wed, Apr 11, 2018 at 12:51:55AM -0400, Allan Jude wrote: > On 2018-04-10 09:56, Mark Johnston wrote: > > Author: markj > > Date: Tue Apr 10 13:56:06 2018 > > New Revision: 332365 > > URL: https://svnweb.freebsd.org/changeset/base/332365 > > > > Log: > > Set zfs_arc_free_target to v_free_target. > > > > Page daemon output is now regulated by a PID controller with a setpoint > > of v_free_target. Moreover, the page daemon now wakes up regularly > > rather than waiting for a wakeup from another thread. This means that > > the free page count is unlikely to drop below the old > > zfs_arc_free_target value, and as a result the ARC was not readily > > freeing pages under memory pressure. Address the immediate problem by > > updating zfs_arc_free_target to match the page daemon's new behaviour. > > > > Reported and tested by: truckman > > Discussed with: jeff > > X-MFC with: r329882 > > Differential Revision: https://reviews.freebsd.org/D14994 > > > > On a somewhat unrelated note, can we rename this sysctl and change to be > counted in bytes? When users are tuning ZFS, every other ZFS value is in > bytes, not pages. > > Maybe keep the currently variable as it is, in pages, and adjust it by > dividing the user set value by the page size. > > The current name is great, but I wouldn't want anyone to end up setting > it to 4096x the value they actually want if we just changed it out from > under them. Sure, any suggestions for what the new sysctl should be named?