From owner-freebsd-geom@FreeBSD.ORG  Mon Sep 17 16:40:06 2007
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5242016A421
	for <freebsd-geom@hub.freebsd.org>;
	Mon, 17 Sep 2007 16:40:06 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 4038513C4B3
	for <freebsd-geom@hub.freebsd.org>;
	Mon, 17 Sep 2007 16:40:06 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l8HGe60x073010
	for <freebsd-geom@freefall.freebsd.org>; Mon, 17 Sep 2007 16:40:06 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l8HGe6ol073009;
	Mon, 17 Sep 2007 16:40:06 GMT (envelope-from gnats)
Date: Mon, 17 Sep 2007 16:40:06 GMT
Message-Id: <200709171640.l8HGe6ol073009@freefall.freebsd.org>
To: freebsd-geom@FreeBSD.org
From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@deepcore.dk>
Cc: 
Subject: Re: kern/115572: [gbde] gbde partitions fail at 28bit/48bit LBA
 addressing boundary
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@deepcore.dk>
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Sep 2007 16:40:06 -0000

The following reply was made to PR kern/115572; it has been noted by GNATS.

From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@deepcore.dk>
To: Pete <xd888cc7541309c3f@f4n.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: kern/115572: [gbde] gbde partitions fail at 28bit/48bit LBA addressing
 boundary
Date: Mon, 17 Sep 2007 18:32:45 +0200

 Pete wrote:
 > Does anyone know if S=F8ren Schmidt's patch (repeated below) is safe to=
 
 > use, and if it is, when it will be commited?
 >
 > I'm also experiencing this problem, but I haven't dared to try the
 > patch yet.
 >
 >  =20
 It is safe to use, it fixes a real bug :)
 
 Its just me being way too busy that has held it back from asking commit=20
 approval..
 
 -S=F8ren
 > The patch:
 >
 > --- ata-all.c 23 Feb 2007 16:25:08 -0000 1.279
 > +++ ata-all.c 19 Aug 2007 09:25:58 -0000
 > @@ -738,7 +738,7 @@
 >
 >  =20
 >> atadev-flags &=3D ~ATA_D_48BIT_ACTIVE;
 >>    =20
 >
 > - if ((request->u.ata.lba >=3D ATA_MAX_28BIT_LBA ||
 > + if (((request->u.ata.lba + request->u.ata.count) >=3D ATA_MAX_28BIT_L=
 BA ||
 >  =20
 >> request-> u.ata.count256) &&
 >> atadev-param.support.command2 & ATA_SUPPORT_ADDRESS48) {
 >>    =20
 >
 > .
 >
 >  =20