From nobody Mon Jul 15 19:20:41 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WNBqv0Vg0z5RVqY; Mon, 15 Jul 2024 19:20:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WNBqt5bGlz4Xkk; Mon, 15 Jul 2024 19:20:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721071242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EPAPmbwXKfNrY2d0Wx8aNxbT7JKNQHKGC1yXxefQjzc=; b=ydzJQo637h4nldceTZbAasKodsaIQgauFa/a0RPGTyemXU2+sJ7DxI325/RNvzEIw7cwRl wrRemVsWqaF4uD5789S+q4K4VCtKpOvN5SjLi0CpDPwd4XI2TGTlCN218Soc+IswVmgnmP R5YKFRM+9lTjtVuMdW7Fw4E/pRo6XrAtXJlRB8TWKF5gok6K06HEARy+mlmmP+1Q6mQHWh ZeLopzu3NRUxbkYQaiiI97fuxGYd5e+s+MIcUZs7wh05X/kE7hi4XlRU/oeUShOtPY/aZS om1RNTu6ggfsRE9/lFHpJ1lZzt7zeT6vzliThF/pYrXh34XixHeFM6lQVgC+CA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1721071242; a=rsa-sha256; cv=none; b=G7OEQdqaBLZDYLdyKCvOVF7Un8riyDH630DEdbYaNodNNRfBguAUZ0+iILOac5ceOQyxTA GWyQKfSryrErb8cPwoVl1zVtLvzjV7A7dPh1sxryc/HOLtf/ksu6ctIDCjM3lqjRBU+SJw 8lUQK+4jmKVQs2opnJHK1H9u8nJ2fQmn7D0HvUpdJkkyTArDWnlbP1aMGD1XIMm5S1unlG oGjVn+PJ9ngE4jBl2GBK62Xb7njn6nQGygdSkqEVPMCrxxu16nOnwlBHk9UGznLVaE6tVz VBSzirORKzCSk+NRtuiIMMIvf6MaRPk2WQdxErvXZ6H74BKu0QzjJS3GOTVClg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721071242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EPAPmbwXKfNrY2d0Wx8aNxbT7JKNQHKGC1yXxefQjzc=; b=wO9WRZueAZPyqQpr4sQKJI9b1thk1VUo4tb047H7WV6pxEykKgsheZL0Xb1pA+S6oY5VKE xvFttndNSB4va/1Iwr7/l24OSWcK1hT9nTkt0hPA5QTPaUay48hS3UJTwVNxJ6itknXTQ/ 1AU+PR2v9TZeuxyKGSPQIDroamp6kAQHWXXI7DulJWSMMDn0dOI75Adpe6fZCrXgfpUOew xJod4mGQ7b7e7IHkAlks3wHBqXRdhIGk8FMexkTR28DfgHaOrw2tP9xR80VvMaslm/WLbP DnNjCguBYm6VAgWVCBc1gdK4flDb+drH8aKgIHo/Ewue8CMEXb2BHp4DMlIHzw== Received: from [IPV6:2601:5c0:4200:b830:28d3:efa9:9f5c:a97f] (unknown [IPv6:2601:5c0:4200:b830:28d3:efa9:9f5c:a97f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WNBqt3xt2z1Prx; Mon, 15 Jul 2024 19:20:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Mon, 15 Jul 2024 15:20:41 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 9cc06bf7aa28 - main - amd64 GENERIC: Switch uart hints from "isa" to "acpi" Content-Language: en-US From: John Baldwin To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202407151915.46FJFr7L039362@gitrepo.freebsd.org> In-Reply-To: <202407151915.46FJFr7L039362@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/15/24 15:15, John Baldwin wrote: > The branch main has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=9cc06bf7aa2846c35483de567779bb8afc289f53 > > commit 9cc06bf7aa2846c35483de567779bb8afc289f53 > Author: John Baldwin > AuthorDate: 2024-07-15 19:14:01 +0000 > Commit: John Baldwin > CommitDate: 2024-07-15 19:15:29 +0000 > > amd64 GENERIC: Switch uart hints from "isa" to "acpi" > > This causes these hints to be only used to wire device unit numbers > for serial ports enumerated by ACPI but will not create ISA device > nodes if ACPI doesn't enumerate them. Note that IRQ hints are not > used for wiring so have been removed. > > PR: 270707 > Reported by: aixdroix_OSS@protonmail.com, Michael Dexter > Reported by: mfw_burn@pm.me, Hannes Hfauswedell > Reported by: Matthias Lanter > Reported by: William Bulley > Reviewed by: imp > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D45945 > --- > sys/amd64/conf/GENERIC.hints | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/sys/amd64/conf/GENERIC.hints b/sys/amd64/conf/GENERIC.hints > index 7c2a3f28b9ce..4f6121c7cf77 100644 > --- a/sys/amd64/conf/GENERIC.hints > +++ b/sys/amd64/conf/GENERIC.hints > @@ -6,13 +6,11 @@ hint.psm.0.at="atkbdc" > hint.psm.0.irq="12" > hint.sc.0.at="isa" > hint.sc.0.flags="0x100" > -hint.uart.0.at="isa" > +hint.uart.0.at="acpi" > hint.uart.0.port="0x3F8" > hint.uart.0.flags="0x10" > -hint.uart.0.irq="4" > -hint.uart.1.at="isa" > +hint.uart.1.at="acpi" > hint.uart.1.port="0x2F8" > -hint.uart.1.irq="3" > hint.atrtc.0.at="isa" > hint.atrtc.0.port="0x70" > hint.atrtc.0.irq="8" Warner would like to purge more of this file (almost all of it) which is probably correct. Warner believes that the uart0 flags to set serial console aren't needed for loaders from FreeBSD 9+ due to the hw.uart.* tunables modern loaders set. I'm less certain about hints for "fixed" devices such as attimer0, atrtc0, and atkbdc0. I feel like some systems have failed to enumerate those in the past, though such systems may be i386-only. The sc0 hints I think can go away once we fully deprecate sc(4) in favor of only vt(4). I've chosen to leave i386 alone as there's still some ancient i386 cruft, but on amd64 we have a higher bar (e.g. ACPI is de facto required for amd64). Also, i386 kernels have one foot in the grave already. This commit is also somewhat narrow in scope as I plan to merge it back to 13 and 14. -- John Baldwin