From nobody Thu Jan 9 01:45:47 2025 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YT70s44myz5kQvW for ; Thu, 09 Jan 2025 01:46:05 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YT70s145zz54bS for ; Thu, 9 Jan 2025 01:46:05 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5d7e3f1fc01so623604a12.2 for ; Wed, 08 Jan 2025 17:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736387164; x=1736991964; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=czZUTHGcfC4o31lkJR0PQwhPJ2dTyi9nXRZict2FhEU=; b=jUEO9CWXMup3bQBlZJYgkdzBANqOmu8/P12PlWpCVMGuh7w0Kdfipq2vjEm0HAnkk9 hLAg6xKV03fgQOnN6nZpXaLIPz857ARdlu7N+IxbFQ74JRIiq1ON/dUNWR/shA2CX4+I WiOzShBAOD8kiBKEjzSmkD+izBhxuWpT6dFs7himXZs8RPsQ2Amst+MIdmlyU7Se9zYo GlBOjkmQcNvpMPY7IaqptGxcU57B71Wjeq13sEsfoH+tC8DTSb6SJH4YWynUUWeIf/Rt lW2OQBedy8MRmGjN9prhvdQ5fhHWSjJDLi8b9biEntwRJOtruuw+JVeHbfSh+f3gioOQ CwRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736387164; x=1736991964; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=czZUTHGcfC4o31lkJR0PQwhPJ2dTyi9nXRZict2FhEU=; b=A+B90hPya2pNG8p9w1qLElyR1ZJk0RUfL4CEimsmzpoxV1wMeqbJ2bKPoMGQJjCVd1 2WpoHLxo3mbleA7HwZRmLkxfHcgErsPBTUu2Tux7Rbn91HZoOjJEy6Z+SkuiqRGqWPeX j4piXpPfLwSNmppJI9fbp/kt9zimhFHkXVnuNymWVq5TFPRIwvXYfsXfEG04vRCxeZbo kZlpK0yo3gDC6ZQPNdZgNn70MSHOVOu4HJ8NPEK33LoNR3r7OTdg+8xtxY4ednONof8O wu/KaJiV7ErcoLwynf4zSGoTDZreRyZ231uYpD1/7Q/d+4qkEsuaKjVfuCDMeYgdzrd4 hKgg== X-Gm-Message-State: AOJu0YynScs9JhiNV3VMeWB3ZwjoKc+C8EWRI6N7QG+4Fb4J9m4XVN6Y dGj1N4YrQ5lV15E3qS5Bdh5p3E9iU18o61j1ikmjoEeFqbq6GMUd7WIa0t1KL1H9/qs2yZrOqDc 76FjzMtN24RLPX59TJpFOqinDnA== X-Gm-Gg: ASbGncuOhKd8D9oxlUUcbom9brHv+EbwfqyJEoiaVXg4WFjXO/CfMPJHPhocnVmqmTu zGzfDcv002BtMWefAOxdl5YVQW/qteYQWydwM9FgzK3PFnSVfG3/HHZw2P/ygig2dSUjNTXE= X-Google-Smtp-Source: AGHT+IFHuOi1l3kxbaEJrk2tEMsLfaS9u3MhRH8qte2QJXz5rXYKWhzjaDCeq3Vzo508UsyLsv7Tt9vXd8fB0xQaxT4= X-Received: by 2002:a05:6402:5243:b0:5d3:ce7f:ac05 with SMTP id 4fb4d7f45d1cf-5d972e6e675mr4128105a12.31.1736387163682; Wed, 08 Jan 2025 17:46:03 -0800 (PST) List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Rick Macklem Date: Wed, 8 Jan 2025 17:45:47 -0800 X-Gm-Features: AbW1kvZO42xl3VHaMFsPtnkI19O0d2zkTaEo_c0peCdoXJUh3AP4ElzI_fnW5_o Message-ID: Subject: Re: RFC: Marking file system va_filerev style To: Konstantin Belousov Cc: Freebsd fs , richard@kojedz.in Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4YT70s145zz54bS X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] On Wed, Jan 8, 2025 at 5:37=E2=80=AFPM Konstantin Belousov wrote: > > On Wed, Jan 08, 2025 at 04:39:36PM -0800, Rick Macklem wrote: > > Hi, > > > > Back in Sept. Richard reported a problem with a > > FreeBSD server serving NFSv4 to Linux clients, > > where the file attributes would get messed up > > sometimes. (I can't recall if he posted me or a mailing > > list.) > > > > Anyhow, He tried a patch I gave him that told the > > Linux client that the Change attribute (va_filerev) > > increments for each change. > > --> This appears to have fixed the problem. > > > > However, this patch should really report what the > > exported fs does w.r.t. va_filerev and not just guess > > that it increments it. > > > > So, the question is, how do I have file systems report > > how they generate va_filerev? > > My current thought is a new MNTK_xxx flag set by > > the filesystem in its mount point to indicate it increments > > it upon each change (which is what UFS and ZFS currently > > does, I think?) > > > > Does this sound reasonable? > > Is this a per-mount property, or a generic filesystem-type property (for > me, the nature of the indicated feature tends to mean per-type). Then > it might be that a VFCF_ flag is the more natural solution than MNTK_ one= . > Yes, it is a file system property. Thanks for the suggestion. (I'll come up with a patch and put it on phabricator.) Thanks, rick