From nobody Tue Jun 14 16:50:04 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 33D49839E32; Tue, 14 Jun 2022 16:50:11 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LMvYv0pRNz3JZd; Tue, 14 Jun 2022 16:50:11 +0000 (UTC) (envelope-from bz@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655225411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=40H13LCzg0WcpryJs4Ez+JcDN7HE/uHgA3ctGnAQ6cY=; b=PDgND3Fql/pZBqJRho0WfcfKHU7BdrLfDiL6VlUxmcytal06rRwZQ8tozwHPVZVATtEgSB +X8HpCeieplvdfUcMx+TrsXBZwezDDYOBvAb0m/T2fTJR6XKeMjp6EMzQdXdJpWofrckyK GdsLbzBUrBiDPuw7sd7pXef7F3OvqkXZEY2ZNUPp0YcDEIFw19u5Jvbi1OfBHcUHSAx/aN DrLRn83V+B8BtER1Jap/AiPw3DxWMFRd2DodpkSUeu7u+9GjU2GKbcau+w4iLZphjN6T9G QoD2tmiWKRJodjM/1bwRNIHpfiKbDXcNJnGDTVi3iW9hEqw3go70f6uesVd9Tw== Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id D4E67B142; Tue, 14 Jun 2022 16:50:10 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 494658D4A179; Tue, 14 Jun 2022 16:50:07 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 61692E707D7; Tue, 14 Jun 2022 16:50:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id Pb77HNIEqfwB; Tue, 14 Jun 2022 16:50:06 +0000 (UTC) Received: from nv.sbone.de (nv.sbone.de [IPv6:fde9:577b:c1a9:31::2013:138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 8E535E707C7; Tue, 14 Jun 2022 16:50:05 +0000 (UTC) Date: Tue, 14 Jun 2022 16:50:04 +0000 (UTC) From: "Bjoern A. Zeeb" To: John Baldwin cc: Warner Losh , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0f7b9777f8f3 - main - rtw88: split driver up into a core and pci part In-Reply-To: <0e2172f8-21c1-afb1-9d2b-03ef14a4edf5@FreeBSD.org> Message-ID: References: <202206121843.25CIhcLr014633@gitrepo.freebsd.org> <0e2172f8-21c1-afb1-9d2b-03ef14a4edf5@FreeBSD.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655225411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=40H13LCzg0WcpryJs4Ez+JcDN7HE/uHgA3ctGnAQ6cY=; b=hQycMhoWwxwroAAKJDaDgFAAXHeGuJv/ziNAdUnoT7PfMOPdFwkohUReIi0Tvs5o6OFuJ/ qVPQc3A5PcfsNW4ch3evMnr1Rt4A8MVTOikKlP/mgMBMxzpKBIFogHF3AguxChdy5m4Xhc ZM15eC7IheYGtA359YCbW5PUCr15DvJDbwh3FvkZERgrmJFucxXB2Dhz3H9MXS47bEA0pT l7PxqEXmU75wWoIJB7ga4helAbt2DhS1OR8YjYUxm4yYNeFSSjrf0PiDFrhlNcHUyhiIKg 2dDaoOrnwpke1iVS/Wkvwfj41bYXwvcnVBENVkCmYc9MinBhQJAeLhSLi64AZA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1655225411; a=rsa-sha256; cv=none; b=QQPSBlXIzFpvFvnepCiGLKEOuG/3uzLrxffFbLLAwfxldW89gdIBHZaMHDmFENYvhFhgfe LCDjVL29qVd9oiJq9YwskKfT2h5iVAsPzMar5z7bZIM5Qi22MZnrD8ST++3nFKJq+isJfu mrMYi43Y4XjZ765EeHB1U+rVrNKYpdmry3FrFGeXqV3MWH1NO6wC06z9dbjJ5PmCYxlCEl 47ORtwkop+afOmN/hoFxAX+d6sIyiTIhwChk2Y/5Yo6lOQ0vWZaYPVhhIvHbXqFKUC3Hvl PlsF4Unp6jlNYshRPrgcU8etob5mkLFviOd1XjgcwXosAAcTQswP8EH2bX4Y2w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Tue, 14 Jun 2022, John Baldwin wrote: >> Why do I need to load 1M file for PCI on a machine w/o PCI? > > Even many SoC boards have PCI, and anything approaching desktop class > will have PCI, so lack of PCI is quite specious. That said, historically > per-bus attachment code was indeed much smaller. OTOH, you can also > selectively include files in the .ko at build-time, e.g. based on > whether or not the base kernel included 'device pci' by checking for > DEV_PCI in KERN_OPTS, something like: > > .if ${KERN_OPTS:MDEV_PCI} > SRCS+= if_rtw88_pci.c > .endif > > This more closely matches what happens in the kernel where you would have > the sys/conf/files line be 'if_rtw88_pci.c optional rtw88 pci' I like this idea and it indeed more closely matches the intentions and seems to be a better idea. I'll revert the change and adjust it to this if that's acceptable? /bz -- Bjoern A. Zeeb r15:7