Date: Tue, 14 Jun 2022 16:50:04 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@freebsd.org> To: John Baldwin <jhb@FreeBSD.org> Cc: Warner Losh <imp@bsdimp.com>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0f7b9777f8f3 - main - rtw88: split driver up into a core and pci part Message-ID: <alpine.BSF.2.00.2206141648460.68830@ai.fobar.qr> In-Reply-To: <0e2172f8-21c1-afb1-9d2b-03ef14a4edf5@FreeBSD.org> References: <202206121843.25CIhcLr014633@gitrepo.freebsd.org> <d514e0de-9b30-b5c8-2e2f-7e93a36747f7@FreeBSD.org> <CANCZdfoqnsJKLtqrwpY35EMGKoQvEYnn158HQNBHEg1=X%2BKZZA@mail.gmail.com> <alpine.BSF.2.00.2206131640300.68830@ai.fobar.qr> <0e2172f8-21c1-afb1-9d2b-03ef14a4edf5@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 14 Jun 2022, John Baldwin wrote:
>> Why do I need to load 1M file for PCI on a machine w/o PCI?
>
> Even many SoC boards have PCI, and anything approaching desktop class
> will have PCI, so lack of PCI is quite specious. That said, historically
> per-bus attachment code was indeed much smaller. OTOH, you can also
> selectively include files in the .ko at build-time, e.g. based on
> whether or not the base kernel included 'device pci' by checking for
> DEV_PCI in KERN_OPTS, something like:
>
> .if ${KERN_OPTS:MDEV_PCI}
> SRCS+= if_rtw88_pci.c
> .endif
>
> This more closely matches what happens in the kernel where you would have
> the sys/conf/files line be 'if_rtw88_pci.c optional rtw88 pci'
I like this idea and it indeed more closely matches the intentions and
seems to be a better idea. I'll revert the change and adjust it to this
if that's acceptable?
/bz
--
Bjoern A. Zeeb r15:7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.2206141648460.68830>