From owner-freebsd-amd64@FreeBSD.ORG Thu Feb 15 17:35:00 2007 Return-Path: X-Original-To: amd64@freebsd.org Delivered-To: freebsd-amd64@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A2B7D16A400 for ; Thu, 15 Feb 2007 17:35:00 +0000 (UTC) (envelope-from steve@virtual-voodoo.com) Received: from energistic.com (mail.energistic.com [216.54.148.60]) by mx1.freebsd.org (Postfix) with ESMTP id 6555513C481 for ; Thu, 15 Feb 2007 17:35:00 +0000 (UTC) (envelope-from steve@virtual-voodoo.com) Received: from stevenew (static-71-98-118-50.ipslin.dsl-w.verizon.net [71.98.118.50]) (authenticated bits=0) by energistic.com (8.13.8/8.13.8) with ESMTP id l1FHYtHP072149; Thu, 15 Feb 2007 12:34:57 -0500 (EST) (envelope-from steve@virtual-voodoo.com) Message-ID: <00b601c75127$9bda5520$d200040a@eservoffice.com> From: "Steve Ames" To: "Sean McNeil" References: <000801c7507f$489a7820$3200010a@ferrari> <001a01c7511a$e736db40$d200040a@eservoffice.com> <1171560484.32243.11.camel@triton.mcneil.com> Date: Thu, 15 Feb 2007 12:34:55 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1807 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1896 X-Spam-Status: No, score=-7.4 required=5.0 tests=AWL,BAYES_00,SPF_FAIL, USER_IN_WHITELIST_TO autolearn=no version=3.1.7 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on energistic.com Cc: amd64@freebsd.org Subject: Re: pwlib has been broken for some time X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Feb 2007 17:35:00 -0000 Sean McNeil wrote: > On Thu, 2007-02-15 at 11:03 -0500, Steve Ames wrote: >> ? Using the default system gcc? Its definately broke on amd64 using >> gcc4.1 due to some 32/64 bit casting errors. But I expect with the >> default gcc it should be compiling. Otherwise the automatic port >> testing utilitiy would have sent me hate mail. >> >> http://pointyhat.freebsd.org/errorlogs/ >> >> Seems to indicate that pwlib is building fine on amd64 under FBSD 5, >> 6 and 7. > > Yes, this is with the default system compiler on 6.2. The problem > with the automatic port testing system is that it will not test all > configurations. For instance, it doesn't set WITH_DEBUG and it looks > like this is the problem. I end up with > [SNIP] > It turns out that WITH_DEBUG removes all options that start with -f > from within /usr/ports/Mk/bsd.port.mk. This is bad for your port as > you add -fPIC in the top Makefile. More appropriately, you should be > doing the same thing Solaris or Linux does in the make/unix.mak file > and add it in there. K. Not unreasonable. As I said I have no way of testing that (so amd64 hardware) and cannot create/submit a patch without testing. Suggest you create and test that patch and submit a PR... or (as a non-optimal workaround, stop using the WITH_DEBUG option) or... (even less optimal to the project as a whole perhaps) create a local patch for yourself and use it. Is this correct WITH_DEBUG behavior in the first place? -Steve