From owner-freebsd-current@freebsd.org Thu Apr 9 01:52:12 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9C4E82AA47A for ; Thu, 9 Apr 2020 01:52:12 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48yPK81Cm3z3QyX for ; Thu, 9 Apr 2020 01:52:12 +0000 (UTC) (envelope-from david@catwhisker.org) Received: by mailman.nyi.freebsd.org (Postfix) id 299712AA479; Thu, 9 Apr 2020 01:52:12 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 295A02AA478 for ; Thu, 9 Apr 2020 01:52:12 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from mx.catwhisker.org (mx.catwhisker.org [107.204.234.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48yPK66Xwfz3QyS; Thu, 9 Apr 2020 01:52:10 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from albert.catwhisker.org (localhost [127.0.0.1]) by albert.catwhisker.org (8.15.2/8.15.2) with ESMTP id 0391q8Ep051339; Thu, 9 Apr 2020 01:52:08 GMT (envelope-from david@albert.catwhisker.org) Received: (from david@localhost) by albert.catwhisker.org (8.15.2/8.15.2/Submit) id 0391q8UT051338; Wed, 8 Apr 2020 18:52:08 -0700 (PDT) (envelope-from david) Date: Wed, 8 Apr 2020 18:52:08 -0700 From: David Wolfskill To: current@freebsd.org Subject: PORTS_MODULES if you built head between r359681 - r359690 Message-ID: <20200409015208.GC1689@albert.catwhisker.org> Reply-To: current@freebsd.org Mail-Followup-To: current@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QK8nhFMwR+o7J1de" Content-Disposition: inline X-Rspamd-Queue-Id: 48yPK66Xwfz3QyS X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of david@catwhisker.org designates 107.204.234.170 as permitted sender) smtp.mailfrom=david@catwhisker.org X-Spamd-Result: default: False [-2.07 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[current@freebsd.org]; REPLYTO_EQ_TO_ADDR(5.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:107.204.234.170]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[catwhisker.org]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_TLS_LAST(0.00)[]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:7018, ipnet:107.192.0.0/12, country:US]; FORGED_RECIPIENTS(0.00)[current@freebsd.org,current@freebsd.org ...]; IP_SCORE(-2.67)[ip: (-9.72), ipnet: 107.192.0.0/12(-4.86), asn: 7018(1.27), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2020 01:52:12 -0000 --QK8nhFMwR+o7J1de Content-Type: text/plain; charset=us-ascii Content-Disposition: inline TL;DR: You may want to take evasive action, such as manually copying the r359690 (or later) from src/share/mk/bsd.sys.mk to /usr/share/mk/bsd.sys.mk before attempting to make use of the PORTS_MODULES specificsation if the current version of /usr/share/mk/bsd.sys.mk is from r359681. Details & rationale: I track head daily on my laptop, which uses x11/nvidia-driver, so I have: PORTS_MODULES=x11/nvidia-driver in /etc/src.conf -- and that has served well for years. Yesterday, I had updated head from r359656 to r359686 without incident (as far as I could tell at the time). Today, during the attempt to update from r359686 to r359724 -- which had worked on my headless "build machine" -- failed during the attempt to rebuild nividia.ko, whining: make[6]: "/usr/share/mk/bsd.sys.mk" line 219: Malformed conditional (${MK_CLANG_BOOTSTRAP} == "no" && ${COMPILER_RESOURCE_DIR} != "unknown" && !defined(BOOTSTRAPPING)) make[6]: Fatal errors encountered -- cannot continue make[6]: stopped in /common/S4/obj/usr/src/amd64.amd64/sys/CANARY/common/ports/x11/nvidia-driver/work/NVIDIA-FreeBSD-x86_64-440.64/doc *** Error code 1 Once I finally(!) had a chance to look at the commits between r359686 and r359724, I found r359690 ... and looking at the whine, I note that the path for share/mk/bsd.sys.mk starts with /usr -- which, of course, had not yet been updated, since this was part of "make buildkernel," and "make installworld" comes rather later in the sequence (ref src/UPDATING). Once I realized the above, I made the r359690 changes in /usr/share/mk/bsd.sys.mk, then re-ran the build/install, which worked without issue. Peace and good health, david -- David H. Wolfskill david@catwhisker.org "The most basic duty of government is to defend the lives of its own citizens. Any government that fails to do so is a government unworthy to lead." -- Donald Trump, to the RNC, 2016 See http://www.catwhisker.org/~david/publickey.gpg for my public key. --QK8nhFMwR+o7J1de Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE4owz2QxMJyaxAefyQLJg+bY2PckFAl6Of8hfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEUy OEMzM0Q5MEM0QzI3MjZCMTAxRTdGMjQwQjI2MEY5QjYzNjNEQzkACgkQQLJg+bY2 PcmFswgA19/IdJQkxZczPivaVgtYJkfiy3zDuLJXuDzuGOSUm+asHfexL522E0xt KTX0R8ke5j3/TOfykbvQu1t9lzt1VxVPO+NecZTDneuOgO6Mv8ijLV8WI46KiYx0 o8tCM6n1godnPcrB+TIYoN6ekkDqZQg7ayf9DNBwDmjMdpukjmO2jMPBxbSxu4O5 N0HLaBnX6WbUuxO/3qEOkoByK6cjV4rPtn7LyHoB9Is7FEljEqa0tt1wqJSwBtXl isX68p8Z+AhUkfseNCVrEuwd7sJrqeWcnSs1vQIvwHqJTvAMwKqau7dcdOu07abb Rq9G9GMCoB3UPjiO50VexGV0cB0nwg== =ZZko -----END PGP SIGNATURE----- --QK8nhFMwR+o7J1de--