From owner-freebsd-arch@FreeBSD.ORG Sat Jan 17 19:11:11 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 60A829BF; Sat, 17 Jan 2015 19:11:11 +0000 (UTC) Received: from mail-wg0-x231.google.com (mail-wg0-x231.google.com [IPv6:2a00:1450:400c:c00::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 028D5D49; Sat, 17 Jan 2015 19:11:11 +0000 (UTC) Received: by mail-wg0-f49.google.com with SMTP id l18so25516wgh.8; Sat, 17 Jan 2015 11:11:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=v6jicreNp+iU9J+2pinh4dDEBuH3xAlE72cgbT3I0LY=; b=rJejnzvxq6OzLB0CdCrbDSKhP6WGJOn/B5ySq5KAuDPJcaPB+t9EuKxsqcJXcr5xyV oAk5MOEOXl/XadjbQccfJrwMXa2/Q079Z7s2/4d23vXrQ4YPaUvT+m1u14vrBnSnZUBB Qf7NVpMBRXxjco3jM0L5IR45Z0VgNmdMvzbv8/Z83yPHu2vf67gC+d6tDTU2z2CTE8id jKNqqIDxgUvoSovTYZA8rfLzeV/tGzk25DJluV5bA3b4NS7s9LE0555e9Hyz5waMHPDm X8vhlC95VQgvaqppba77ZMvofb/UUDgzdVRNzV3DDd0RVYwq7NVclS2c0AY8OoxzNFzj ZhNQ== MIME-Version: 1.0 X-Received: by 10.180.104.9 with SMTP id ga9mr18890378wib.9.1421521868935; Sat, 17 Jan 2015 11:11:08 -0800 (PST) Received: by 10.216.37.68 with HTTP; Sat, 17 Jan 2015 11:11:08 -0800 (PST) In-Reply-To: <54B7DECF.8070209@selasky.org> References: <54A1B38C.1000709@selasky.org> <20150101005613.4f788b0c@nonamehost.local> <54A49CA5.2060801@selasky.org> <54A4A002.8010802@selasky.org> <54A53F4F.2000003@selasky.org> <54A92ED1.2070906@selasky.org> <54A9A71E.70609@selasky.org> <54B29A49.3080600@selasky.org> <54B67DA7.3070106@selasky.org> <54B7DECF.8070209@selasky.org> Date: Sat, 17 Jan 2015 12:11:08 -0700 Message-ID: Subject: Re: [RFC] kern/kern_timeout.c rewrite in progress From: Jason Wolfe To: Hans Petter Selasky , John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: Adrian Chadd , FreeBSD Current , Sean Bruno , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Jan 2015 19:11:11 -0000 On Thu, Jan 15, 2015 at 8:37 AM, Hans Petter Selasky wrote: > On 01/14/15 15:31, Hans Petter Selasky wrote: >> >> On 01/11/15 19:08, Jason Wolfe wrote: >>> >>> Hans, >>> >>> We've had 50 machines running 10.1-STABLE with this patch for the >>> better part of a week without issue. Prior we would have seen a panic >>> every few days at the least, so things are looking very promising on >>> our front. >>> >>> Jason >> >> >> Hi, >> >> I've updated D1438 including the manual page changes needed for >> timeout.9 aswell in addition to a minor fix for those using timeout() >> and untimeout() and KTR(). >> >> https://reviews.freebsd.org/D1438 >> >> --HPS > > > FYI: > > Now in -current: > > https://svnweb.freebsd.org/changeset/base/277213 > > Thanks for all good comments and reviews. > > --HPS HPS, Just to give a quick status update, this patch has most certainly resolved our spin lock held too long panics on stable/10. Thank you to JHB for spending some time digging into the issue and leading us to td_slpcallout as the culprit, and HPS for your rewrite. I had heard rumors of other being affected by similar issues, so this seems like a fine candidate for an MFC if possible. Jason