From nobody Sun Mar 31 20:17:09 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V756g5PlLz5GLcS for ; Sun, 31 Mar 2024 20:17:47 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V756g4jctz4XrC for ; Sun, 31 Mar 2024 20:17:47 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711916267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fxfLiIb9XFCJ/YcL/LWi0drkZJpzoFarfGvUb8VHGHI=; b=ncHnYGeXF17Yn4aPG61r5AfRCEfduI7AhAFU4UpOxpMsyuR0t7c6O8ldKe/liQVjZH+W7F yPFFs4pJi8bN4wTBFjYgJzWNekAYn+R+vf45zbKh8WHZ97TxzmaLenUqCmlLKotgiUBUDJ 0ZxG/Rndb81oSCKHp6tpRGjYyl8NYNgRtdjiXeMUmbhrypjR9KNmJMP+RjtBp3dDMgb37S dvvW8cpLTewvAv29dt9aFby1GWCong/1DvDQ46Zf27Qu8kwSRzBH/ArY3AC6yTS4NeT16e GxISBKElbC31XwzaiG+RP7phzCDOosHpsuGWLMdeWIh46fnezcwroIe/a+Z2DQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711916267; a=rsa-sha256; cv=none; b=XFAxd4c0A4ZP5CZGwM5EzHTIfwTnADyqoy77XBnhlHaHwH0Y5pWZu5x+BjvNqk7KlObZ7h aA2keg8Fxe7DXxhVdNIRhiIUMpMI+9fE+kX/MRDmWH/Z2K0ufJ8v+csLg4acY6GyEWUbb5 rCoTVKy8ABcB2v6rO+DOHbmLfJn6ZwoRmbZdy8TkeEBUZM2TJt6i3mpP1/LYVv0mvPL+a4 duIJfByemz4OdmuU1ORsmxODOdr9UDOjhsF2CZyBj7c8ExAPuHMPjutrTZ5zttoTEQE34P H/mFMdTFkQYejycWUuNH0NIzFtpw6EbNoyDhHNchvKtK1SFG8To349uQgaVLDw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711916267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fxfLiIb9XFCJ/YcL/LWi0drkZJpzoFarfGvUb8VHGHI=; b=TP83a7VX8h+qXSqBAjthw7HxfaJSlauRfrSIJOkUZLHuWBQpSsc2lerGLWGIJcvXQzVsO1 N8z/Rb5rk6pvYiThgBB5anxAszk7AL1EQVGxtOCiGAm46Q2bGddwGsAP5ya6VX0aNod46k 7PR0ApUOZU1k1YnxH9g/OCODZwsci3Kxffaa/rlatJ8mqBU6KcS7VFYCOtNqDqSWTjkZeX c6bMNpNzpseYwiNRsOO4DwmNGNXEXo5VSmKekZ82vnXtomHVIThnMVB570JKR5idc5n4J/ JigQyCUrGPVefs9K9z+tB53o6DwtkweJFdZlYXWSX6TX0AT0TDtLN2VRx3bKsw== Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V756g4J51zZqf for ; Sun, 31 Mar 2024 20:17:47 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a44665605f3so384332966b.2 for ; Sun, 31 Mar 2024 13:17:47 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXBY1aDBZKdykmSiIDFjX7kokyYVB5f2kJo9+U5uGc3II3EN1hrzKytZAndGJh7clhdmDVYAjVF2iVkWeDICs+1fA+7lX1PDSgPbQf4xDoBFI0V X-Gm-Message-State: AOJu0YwHBfpFxlSCcw7c+P5A/fFyTs1zPNxy/Ta8gtO5UgZPzwu5r8kR KasQ5l9w2w9Hf3uYddNlBN84slQcR7PFMKVWTlc2SdD0078i661tse1G23Okw6sH8Tz+xQ6AUX6 UR6fj7SysEwGrSyJ2TKmw4NKKwbU1RAqzkqcLaA== X-Google-Smtp-Source: AGHT+IHNTgy023njxV3YiVVVuiWny9fyT9BvEJ32YwT+l1sy4qrfu+vFcgmvbbGKVAe2AN9wpfYQQ/ku06t7liOn8DA= X-Received: by 2002:a17:906:9904:b0:a46:53e9:aef9 with SMTP id zl4-20020a170906990400b00a4653e9aef9mr4445956ejb.65.1711916266398; Sun, 31 Mar 2024 13:17:46 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202403231404.42NE4baU095633@gitrepo.freebsd.org> <2567403.0dHE6SNnxz@angua.firefly> <20240324202715.5d18838d@hal.tijl.coosemans.org> In-Reply-To: <20240324202715.5d18838d@hal.tijl.coosemans.org> From: Po-Chuan Hsieh Date: Mon, 1 Apr 2024 04:17:09 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update" To: =?UTF-8?Q?T=C4=B3l_Coosemans?= Cc: "Tobias C. Berner" , Gleb Popov , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000f1c6cc0614fa9002" --000000000000f1c6cc0614fa9002 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 25, 2024 at 3:27=E2=80=AFAM T=C4=B3l Coosemans wrote: > On Sun, 24 Mar 2024 00:12:07 +0800 Po-Chuan Hsieh wrote: > > On Sat, Mar 23, 2024 at 11:38=E2=80=AFPM Tobias C. Berner > > wrote: > >> Am Samstag, 23. M=C3=A4rz 2024, 15:14:01 CET schrieb Gleb Popov: > >>> On Sat, Mar 23, 2024 at 5:04=E2=80=AFPM Po-Chuan Hsieh > >>> wrote: > >>>> The branch main has been updated by sunpoet: > >>>> > >>>> URL: > >>>> > https://cgit.FreeBSD.org/ports/commit/?id=3D28472e9722d808739a4d690f6d803= a2b1b8f5f98 > >>>> > >>>> commit 28472e9722d808739a4d690f6d803a2b1b8f5f98 > >>>> Author: Po-Chuan Hsieh > >>>> AuthorDate: 2024-03-23 14:01:07 +0000 > >>>> Commit: Po-Chuan Hsieh > >>>> CommitDate: 2024-03-23 14:01:07 +0000 > >>>> > >>>> Revert "x11-fonts/noto*: Restructure and update" > >>>> > >>>> This reverts commit 3b128ff9f74b28ada2f475f0b816480b1550e5b8. > >>> > >>> It is good manners to explain the reason for reverting when doing it. > >>> Even better to first talk to the original committer and ask him to th= e > >>> revert. > >> > >> Moin moin > >> > >> I completely agree. Given that there has been a phabricator review ope= n > >> for two months, with you, sunpoet@ as reviewer, this is looking like > poor > >> judgement on your side. > >> > >> As arrowd@ points out, you should have commented on the reverted commi= t > >> first, and elaborate your reasoning for a revert. > >> > >> Simply reverting the work of others may lead to fewer contributions. > >> Please take this into consideration in the future. > >> > >> > >> mfg Tobias > > > > > > Hello, > > > > I'm sorry that I did not put enough information in this reverting commi= t > > because I need it to be done ASAP so that less users are affected. > > There are several reasons I reverted it by myself instead of > > requesting tijl@ to do so. > > First, I do not use phab review therefore I did not really review the > patch > > which means it is committed without maintainer approval. > > Second, I already have my own work for noto updates which is totally in > > different direction with tijl@'s work. I cannot simply rebase my work > onto > > it. > > Third, The problem mentioned in the PR is also handled in my own work. > > > > Regards, > > sunpoet > > I don't mind getting reverted. I do think Noto is large enough that > some thought should go into how we handle it in the ports tree and that > you should have put your alternative up for discussion before committing > it. Here are some (possible) issues with it that should probably be > fixed before the next quarterly: > > - You are using upstream distfiles that are quite large. The distfiles > for the common (Latin, Greek, Cyrillic) fonts Sans, Sans Mono, and > Serif add up to 234MB. These fonts will be installed by almost every > user that uses FreeBSD as a desktop now that DejaVu appears to have > been abandoned. My proposal was to create our own distfiles and I > integrated that into makesum so the only extra step compared to a > normal version update was to upload the generated distfile to > freefall. I was willing to take over maintainership in case you > didn't want to deal with that. These distfiles add up to 27MB. And > if we put the extra weights (ExtraBold,...) and widths (Condensed,...) > in a separate port like you did it would be only 2MB. > The committed one is my second version of noto fonts update. The previous version is to use the individual file from github.com just like those Noto CJK ports. I changed to upstream tarball because it's clearer/simpler and easier to track. I could change it back to the previous version for a smaller distfile footprint. Give me several days to clean up the Makefiles. > - Some fonts have been split into x11-fonts/-basic providing Bold, > BoldItalic, Italic, and Regular, and x11-fonts/-extra providing > additional styles. Only some of these have x11-fonts/ as a > metaport currently. This needs to be made consistent. I think it > would be best to drop the metaports and move x11-fonts/-basic to > x11-fonts/. That way pkg install installs the common > styles for all fonts. I think that this would be the most > intuitive/convenient. > (I was hoping to use subpackages for this instead of extra ports.) > The -basic/-extra structure was kept for minimal change. I agree with you that it would be better to be consistent with all other noto ports. I could merge the following ports: - noto-sans-basic/-extra - noto-sans-mono-basic/-extra - noto-sans-symbols-basic/-extra - noto-serif-basic/-extra However, what should be noto-basic's dependencies after the merge? > - x11/noto-emoji now installs the COLRv1 version of Noto Color Emoji but > this isn't supported yet by graphics/cairo so emoji are broken now in > gtk applications. I think Ghostscript doesn't support it either. It > has to be removed again for now. > It is handled in PR 278019 and ports 2878ca490586207c3cd7bb3ff94d1274f52013b0. > > - Besides Noto Color Emoji there's also the monochrome Noto Emoji that > can be useful in print. I think we should let x11-fonts/noto-emoji > install the monochrome font and move the existing x11-fonts/noto-emoji > to x11-fonts/noto-color-emoji so the names match. > How about putting all emoji in the existing port (x11-fonts/noto-emoji)? --000000000000f1c6cc0614fa9002 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Mar 25, 2024 at 3:27=E2=80=AFAM T= =C4=B3l Coosemans <tijl@freebsd.org> wrote:
On Sun, 24 Mar 2024 00:12:07 +0= 800 Po-Chuan Hsieh wrote:
> On Sat, Mar 23, 2024 at 11:38=E2=80=AFPM Tobias C. Berner <tcberner@gmail.com>=
> wrote:
>> Am Samstag, 23. M=C3=A4rz 2024, 15:14:01 CET schrieb Gleb Popov:= =C2=A0
>>> On Sat, Mar 23, 2024 at 5:04=E2=80=AFPM Po-Chuan Hsieh <sunpoet@freebsd.org>=C2=A0
>>> wrote:=C2=A0
>>>> The branch main has been updated by sunpoet:
>>>>
>>>> URL:
>>>> https://cgit.FreeBSD.org/ports/commit/?id=3D28472e9722d808739a4d690f6d803a= 2b1b8f5f98
>>>>
>>>> commit 28472e9722d808739a4d690f6d803a2b1b8f5f98
>>>> Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@Free= BSD.org>
>>>> AuthorDate: 2024-03-23 14:01:07 +0000
>>>> Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@Free= BSD.org>
>>>> CommitDate: 2024-03-23 14:01:07 +0000
>>>>
>>>>=C2=A0 =C2=A0 =C2=A0Revert "x11-fonts/noto*: Restructu= re and update"
>>>>
>>>>=C2=A0 =C2=A0 =C2=A0This reverts commit 3b128ff9f74b28ada2f= 475f0b816480b1550e5b8.=C2=A0
>>>
>>> It is good manners to explain the reason for reverting when do= ing it.
>>> Even better to first talk to the original committer and ask hi= m to the
>>> revert.=C2=A0
>>
>> Moin moin
>>
>> I completely agree. Given that there has been a phabricator review= open
>> for two months, with you, sunpoet@ as reviewer, this is looking li= ke poor
>> judgement on your side.
>>
>> As arrowd@ points out, you should have commented on the reverted c= ommit
>> first, and elaborate your reasoning for a revert.
>>
>> Simply reverting the work of others may lead to fewer contribution= s.
>> Please take this into consideration in the future.
>>
>>
>> mfg Tobias=C2=A0
>
>
> Hello,
>
> I'm sorry that I did not put enough information in this reverting = commit
> because I need it to be done ASAP so that less users are affected.
> There are several reasons I reverted it by myself instead of
> requesting tijl@ to do so.
> First, I do not use phab review therefore I did not really review the = patch
> which means it is committed without maintainer approval.
> Second, I already have my own work for noto updates which is totally i= n
> different direction with tijl@'s work. I cannot simply rebase my w= ork onto
> it.
> Third, The problem mentioned in the PR is also handled in my own work.=
>
> Regards,
> sunpoet

I don't mind getting reverted.=C2=A0 I do think Noto is large enough th= at
some thought should go into how we handle it in the ports tree and that
you should have put your alternative up for discussion before committing it.=C2=A0 Here are some (possible) issues with it that should probably be fixed before the next quarterly:

- You are using upstream distfiles that are quite large.=C2=A0 The distfile= s
=C2=A0 for the common (Latin, Greek, Cyrillic) fonts Sans, Sans Mono, and =C2=A0 Serif add up to 234MB.=C2=A0 These fonts will be installed by almost= every
=C2=A0 user that uses FreeBSD as a desktop now that DejaVu appears to have<= br> =C2=A0 been abandoned.=C2=A0 My proposal was to create our own distfiles an= d I
=C2=A0 integrated that into makesum so the only extra step compared to a =C2=A0 normal version update was to upload the generated distfile to
=C2=A0 freefall.=C2=A0 I was willing to take over maintainership in case yo= u
=C2=A0 didn't want to deal with that.=C2=A0 These distfiles add up to 2= 7MB.=C2=A0 And
=C2=A0 if we put the extra weights (ExtraBold,...) and widths (Condensed,..= .)
=C2=A0 in a separate port like you did it would be only 2MB.

The committed one is my second version of noto fonts = update.
The previous version is to use the individual file from <= a href=3D"http://github.com" target=3D"_blank">github.com just like tho= se Noto CJK ports.
I changed to upstream tarball because it's= clearer/simpler and easier to track.
I could change it back to t= he previous version for a smaller distfile footprint.
Give me sev= eral days to clean up the Makefiles.


- Some fonts have been split into x11-fonts/<font>-basic providing Bo= ld,
=C2=A0 BoldItalic, Italic, and Regular, and x11-fonts/<font>-extra pr= oviding
=C2=A0 additional styles.=C2=A0 Only some of these have x11-fonts/<font&= gt; as a
=C2=A0 metaport currently.=C2=A0 This needs to be made consistent.=C2=A0 I = think it
=C2=A0 would be best to drop the metaports and move x11-fonts/<font>-= basic to
=C2=A0 x11-fonts/<font>.=C2=A0 That way pkg install <font> inst= alls the common
=C2=A0 styles for all fonts.=C2=A0 I think that this would be the most
=C2=A0 intuitive/convenient.
=C2=A0 (I was hoping to use subpackages for this instead of extra ports.)

The=C2=A0-basic/-extra structure was kep= t for minimal change.
I agree with you that it would be better to= be consistent with all other noto ports.
I could merge = the following ports:
-=C2=A0noto-sans-basic/-extra
-=C2=A0noto-sans-mono-basic/-extra
-=C2=A0noto-sans-symbols-bas= ic/-extra
-=C2=A0noto-serif-basic/-extra
However, what = should be noto-basic's dependencies after the merge?=C2=A0

- x11/noto-emoji now installs the COLRv1 version of Noto Color Emoji but =C2=A0 this isn't supported yet by graphics/cairo so emoji are broken n= ow in
=C2=A0 gtk applications.=C2=A0 I think Ghostscript doesn't support it e= ither.=C2=A0 It
=C2=A0 has to be removed again for now.

It is handled in PR 278019 and ports=C2=A02878ca490586207c3cd7bb3ff94d1274= f52013b0.
=C2=A0

- Besides Noto Color Emoji there's also the monochrome Noto Emoji that<= br> =C2=A0 can be useful in print.=C2=A0 I think we should let x11-fonts/noto-e= moji
=C2=A0 install the monochrome font and move the existing x11-fonts/noto-emo= ji
=C2=A0 to x11-fonts/noto-color-emoji so the names match.

How about putting all emoji in the existing port (x11-fon= ts/noto-emoji)?
--000000000000f1c6cc0614fa9002--