From owner-freebsd-current@freebsd.org  Mon Oct  3 16:41:58 2016
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4A14EAF4D82;
 Mon,  3 Oct 2016 16:41:58 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 0591FD31;
 Mon,  3 Oct 2016 16:41:56 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA28488;
 Mon, 03 Oct 2016 19:41:54 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1br6JO-0005te-DS; Mon, 03 Oct 2016 19:41:54 +0300
Subject: Re: [request for testing] isl, cyapa on chromebooks
To: Michael Gmelin <grembo@FreeBSD.org>
References: <1e66fc64-cdff-e94b-4b0c-55cb05e2b5a1@FreeBSD.org>
 <20161003180750.744dae0a@bsd64.grem.de>
Cc: FreeBSD Current <freebsd-current@FreeBSD.org>, freebsd-mobile@FreeBSD.org
From: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <ecd26145-442d-d059-59a1-139e206d451b@FreeBSD.org>
Date: Mon, 3 Oct 2016 19:41:17 +0300
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20161003180750.744dae0a@bsd64.grem.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Oct 2016 16:41:58 -0000

On 03/10/2016 19:07, Michael Gmelin wrote:
> I upgraded the latter the r306641, applied your patches (cleanly) and
> ran "make kernel" (GENERIC kernel), added the entries to device.hints
> and rebooted. Unfortunately ig4 won't load:
> 
> # kldload ig4
> link_elf_obj: symbol iicbus_transfer_desc undefined
> linker_load_file: Unsupported file type

Hmm, seems like forgot to declare the iicbus module dependency.
Could you please kldload iicbus and see if that helps?
Meanwhile I'll add the dependency.

> I also noticed that isl cannot be built from the module source
> directory:
> 
> # cd /usr/src/sys/modules/i2c/isl
> # make
> ...
> /usr/src/sys/sys/vnode.h:571:10: fatal error: 'vnode_if.h' file not
> found
> #include "vnode_if.h"
>          ^
> 1 error generated
> *** Error code 1
> 
> This can be easily fixed by removing "#include <sys/vnode.h>" from
> isl.c (line 56).

Thank you for reporting this!
Looks like I overlooked this because I didn't do make clean after removing
vnode_if.h from the Makefile.
Will fix this too.

-- 
Andriy Gapon