From owner-freebsd-current Wed Jan 20 23:04:47 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA25517 for freebsd-current-outgoing; Wed, 20 Jan 1999 23:04:47 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from allegro.lemis.com (allegro.lemis.com [192.109.197.134]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA25503 for ; Wed, 20 Jan 1999 23:04:41 -0800 (PST) (envelope-from grog@freebie.lemis.com) Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by allegro.lemis.com (8.9.1/8.9.0) with ESMTP id RAA15777; Thu, 21 Jan 1999 17:34:26 +1030 (CST) Received: (from grog@localhost) by freebie.lemis.com (8.9.2/8.9.0) id RAA29524; Thu, 21 Jan 1999 17:34:25 +1030 (CST) Date: Thu, 21 Jan 1999 17:34:25 +1030 From: Greg Lehey To: Matthew Dillon Cc: Luoqi Chen , current@FreeBSD.ORG Subject: Re: panic: vinvalbuf: dirty bufs (during reboot, several times) Message-ID: <19990121173424.V15785@freebie.lemis.com> References: <199901210536.AAA08007@lor.watermarkgroup.com> <199901210700.XAA10740@apollo.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.1i In-Reply-To: <199901210700.XAA10740@apollo.backplane.com>; from Matthew Dillon on Wed, Jan 20, 1999 at 11:00:34PM -0800 WWW-Home-Page: http://www.lemis.com/~grog Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wednesday, 20 January 1999 at 23:00:34 -0800, Matthew Dillon wrote: >> Sorry, Matt, the patch in my previous email was fatally flawed. Try this one >> below. The two printf() messages don't necessarily come out in pairs and >> it's not just NFS bufs' B_CACHE bits are cleared, so my comment about >> vm_page_is_valid() check in my previous message was wrong and the check is >> needed here. >> >> -lq > > Ok, I understand what you've done... you are effectively bypassing > having to check for B_DELWRI in bread(), breadn(), and nfs_bioread() > by forcing getblk() to handle the B_DELWRI condition. > > Cool. I'll replace my nfs_bioread() patch with this one and test it > before committing all this stuff to the -4.x branch ( which I will also > do sometime tonight ). > > I am also CCing this to current so Greg and Andreas are kept abrest > of events. I think this will fix *both* of their reported panics. Not mine :-) Mine was a bug in vinum which I had already fixed; I was just concerned about whether it had shown its nose again. Greg -- See complete headers for address, home page and phone numbers finger grog@lemis.com for PGP public key To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message