From owner-cvs-src@FreeBSD.ORG Fri Apr 6 05:39:39 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6925F16A401; Fri, 6 Apr 2007 05:39:39 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id DD61213C4B0; Fri, 6 Apr 2007 05:39:38 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.8/8.13.8) with ESMTP id l365dbs3084842; Fri, 6 Apr 2007 09:39:37 +0400 (MSD) (envelope-from ache@nagual.pp.ru) X-DKIM: Sendmail DKIM Filter v0.6.2 nagual.pp.ru l365dbs3084842 Received: (from ache@localhost) by nagual.pp.ru (8.13.8/8.13.8/Submit) id l365dZtT084841; Fri, 6 Apr 2007 09:39:35 +0400 (MSD) (envelope-from ache) Date: Fri, 6 Apr 2007 09:39:35 +0400 From: Andrey Chernov To: Bruce Evans Message-ID: <20070406053934.GA84722@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Bruce Evans , Pawel Jakub Dawidek , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704052110.l35LAsXH013966@repoman.freebsd.org> <20070406115326.A43678@delplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070406115326.A43678@delplex.bde.org> User-Agent: Mutt/1.5.14 (2007-02-12) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Pawel Jakub Dawidek , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include stdio.h src/lib/libc/sys lseek.2 pathconf.2 src/sys/kern vfs_syscalls.c src/sys/sys filio.h unistd.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2007 05:39:39 -0000 On Fri, Apr 06, 2007 at 11:58:55AM +1000, Bruce Evans wrote: > On Thu, 5 Apr 2007, Pawel Jakub Dawidek wrote: > > >pjd 2007-04-05 21:10:54 UTC > > > > FreeBSD src repository > > > > Modified files: > > include stdio.h > > lib/libc/sys lseek.2 pathconf.2 > > sys/kern vfs_syscalls.c > > sys/sys filio.h unistd.h > > Log: > > Implement SEEK_DATA and SEEK_HOLE extensions to lseek(2) as found in > > OpenSolaris. For more information please refer to: > > > > http://blogs.sun.com/bonwick/entry/seek_hole_and_seek_data > > These are just namespace pollution in stdio.h. stdio (fseek()) doesn't > support them, and the hack of declaring lseek() in stdio.h should not > be extended to new interfaces. If stdio ever supports them, then they > would need to be declared under a visibility ifdef (not #ifdef self). I agree. They must be implemented in fseek.c code first before adding them to stdio.h and ifdefed with proper *_VISIBLE tags in all places. Perhaps new __CDDL_VISIBLE tag required for it. -- http://ache.pp.ru/