From owner-freebsd-current@freebsd.org Sat Apr 29 19:54:14 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 02D86D55312; Sat, 29 Apr 2017 19:54:14 +0000 (UTC) (envelope-from mikej@mikej.com) Received: from mx2.paymentallianceintl.com (mx2.paymentallianceintl.com [216.26.158.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx2.paymentallianceintl.com", Issuer "Go Daddy Secure Certificate Authority - G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C9E8CD28; Sat, 29 Apr 2017 19:54:13 +0000 (UTC) (envelope-from mikej@mikej.com) Received: from firewall.mikej.com (f [162.230.214.65]) by mx2.paymentallianceintl.com (8.15.2/8.15.2) with ESMTPS id v3TJs3RO036629 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 29 Apr 2017 15:54:04 -0400 (EDT) (envelope-from mikej@mikej.com) X-SenderID: Sendmail Sender-ID Filter v1.0.0 mx2.paymentallianceintl.com v3TJs3RO036629 Authentication-Results: mx2.paymentallianceintl.com; sender-id=pass header.from=mikej@mikej.com; spf=pass smtp.mfrom=mikej@mikej.com X-Authentication-Warning: mx2.paymentallianceintl.com: Host f [162.230.214.65] claimed to be firewall.mikej.com Received: from mail.mikej.com (firewall [192.168.6.63]) by firewall.mikej.com (8.15.2/8.15.2) with ESMTP id v3TJs1xO027380; Sat, 29 Apr 2017 15:54:02 -0400 (EDT) (envelope-from mikej@mikej.com) DMARC-Filter: OpenDMARC Filter v1.3.1 firewall.mikej.com v3TJs1xO027380 Authentication-Results: mail.mikej.com; dmarc=none header.from=mikej.com DKIM-Filter: OpenDKIM Filter v2.10.3 firewall.mikej.com v3TJs1xO027380 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mikej.com; s=mail; t=1493495642; bh=cnlzyauvrurjs+CWCvwbZyp7QfvgbTTVjmcoQ9C+/O8=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=SJtcOufXWUaK+p4exPoaSU5vEYeRU96xReSJXW2tFetWfFliosGGkvpmQbHCrpUdi 9lOuY8+vdQnRXYyUrKzH+CDAc72Z1AsIU5M0zMKJtRMU8JmBiPmykNtKhWU+99cAnK AhLaHWXIb+zc90/Ffhr0OA7fqjbIfaW0DXgT/0N65xtYXHMuxzGnN1QBr9P0QDUQ3W 16F8o9J0Qka+s+3INjsD32gsmvOyICtpYEnAOeca/KEqMaaNUw/eq2YrqBLsOS391M y57qWy9+X1aQ1ELBVAf7JVsExoqXgD98C5lwQLR6Z4hLAGZnxa7DxWUvmGcLxPSuvm 1fAUZTy4a4GnA== X-Authentication-Warning: firewall.mikej.com: Host firewall [192.168.6.63] claimed to be mail.mikej.com MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 29 Apr 2017 15:54:00 -0400 From: Michael Jung To: Andriy Gapon Cc: freebsd-current@freebsd.org, owner-freebsd-current@freebsd.org Subject: Re: Panic String: solaris assert: (lsize != psize) implies ((flags & ZIO_FLAG_RAW) != 0), file: /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio.c, line: 631 In-Reply-To: <75e7cde3-b064-5754-192d-00f8a65788b8@FreeBSD.org> References: <32c84a1f-1377-e0a1-1c8b-d22eea80d871@FreeBSD.org> <19ac2524eba83333063822c063c6af3e@mikej.com> <75e7cde3-b064-5754-192d-00f8a65788b8@FreeBSD.org> Message-ID: X-Sender: mikej@mikej.com User-Agent: Roundcube Webmail/1.2.4 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Apr 2017 19:54:14 -0000 On 2017-04-28 17:42, Andriy Gapon wrote: > On 28/04/2017 14:56, Michael Jung wrote: >> I have mad the requested change.. >> >> [root@bsd11 /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs]# >> diff zio.c >> ~mikej/zio.c.orig >> 965c965 >> < size, NULL, NULL, ZIO_TYPE_FREE, ZIO_PRIORITY_NOW, >> --- >>> BP_GET_PSIZE(bp), NULL, NULL, ZIO_TYPE_FREE, >>> ZIO_PRIORITY_NOW, > > Yes, that's the change that I had in mind. > I was a little bit confused by the order of the original and modified > files, > though :-) > >> [root@bsd11 /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs]# >> >> As to the pool size: >> >> [root@bsd11 /usr/home/mikej]# zpool list >> NAME SIZE ALLOC FREE EXPANDSZ FRAG CAP DEDUP HEALTH >> ALTROOT >> tank 199G 143G 55.9G - 85% 71% 1.00x ONLINE - >> [root@bsd11 /usr/home/mikej]# >> >> I should have also mentioned that besides poudriere running a build, >> it was >> removing old logs - There was some 43G of old logs files that were in >> the process >> of being removed. > > So, given that the panic was in the freeing path, you were probably low > on the > pool space back when those log files were created. I mean that the > gang blocks > are typically created when a pool is very fragmented. > >> I will hammer the box with and report back first of the week whether >> the panic >> re-occurs or not. > > Please also try removing those old files again too. > Running zpool scrub afterwards could be a good idea too. > > Thank you again! Andriy: I am happy to report that the system no longer panics. As requested I removed the remaining logs (34G worth) and punished the file system as hard as I could. A scrub of the pool completed without error Will the change be committed or do I need to open a PR? Please let me know if I can supply additional information or if there are any further tests you would like me to perform. Thanks again for you prompt reply and apparent solution. Regards, Michael Jung