From owner-svn-src-head@FreeBSD.ORG Fri Dec 3 13:02:08 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2EAAB1065694; Fri, 3 Dec 2010 13:02:08 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id EF9FE8FC1D; Fri, 3 Dec 2010 13:02:07 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id A192146B7E; Fri, 3 Dec 2010 08:02:07 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id A30688A027; Fri, 3 Dec 2010 08:02:06 -0500 (EST) From: John Baldwin To: Bruce Cran Date: Fri, 3 Dec 2010 07:46:44 -0500 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20101102; KDE/4.4.5; amd64; ; ) References: <201012022219.oB2MJUx5031472@svn.freebsd.org> <20101203201705.O2228@besplex.bde.org> <20101203101651.7461ced0@core.draftnet> In-Reply-To: <20101203101651.7461ced0@core.draftnet> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201012030746.44967.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Fri, 03 Dec 2010 08:02:06 -0500 (EST) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bruce Evans , Bruce Cran Subject: Re: svn commit: r216134 - in head: share/man/man9 sys/amd64/include sys/arm/include sys/i386/include sys/ia64/include sys/mips/include sys/pc98/include sys/powerpc/include sys/sparc64/include sys/sun4v... X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2010 13:02:08 -0000 On Friday, December 03, 2010 5:16:51 am Bruce Cran wrote: > On Fri, 3 Dec 2010 20:45:12 +1100 (EST) > Bruce Evans wrote: > > > KASSERT() in little inline functions gives a lot of bloat for such an > > unlikely error. Stupid callers can still pass any garbage count > > except 0. > > Yes, this catches a specific case that hps raised a few years ago: > sending zero-length packets/frames would fail by causing the system to > hang. Should we just document the restriction in the man page and not > try and prevent it at runtime? Documenting it is probably sufficient. -- John Baldwin