Date: Fri, 27 Dec 2024 17:26:18 +0000 From: Kristof Provost <kp@FreeBSD.org> To: Renato Botelho <garga@FreeBSD.org> Cc: Andrew Turner <andrew@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: ba1904937d9a - main - acpica: Extract _OSC parsing to a common file Message-ID: <AC5C158F-085B-468F-A3C8-1B56524438C9@FreeBSD.org> In-Reply-To: <149116bc-677c-47b2-9ff7-f454418fec21@FreeBSD.org> References: <202412121819.4BCIJ1KW097190__8805.67587898753$1734027579$gmane$org@gitrepo.freebsd.org> <149116bc-677c-47b2-9ff7-f454418fec21@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=_MailMate_B90DBFDC-A7D8-4764-961A-A5BB375C1A68_= Content-Type: text/plain; charset=UTF-8; format=flowed; markup=markdown Content-Transfer-Encoding: quoted-printable On 26 Dec 2024, at 21:44, Renato Botelho wrote: > On 12/12/24 15:19, Andrew Turner wrote: >> The branch main has been updated by andrew: >> >> URL: = >> https://cgit.FreeBSD.org/src/commit/?id=3Dba1904937d9ae0539e39001467a1= 519b17177118 >> >> commit ba1904937d9ae0539e39001467a1519b17177118 >> Author: Andrew Turner <andrew@FreeBSD.org> >> AuthorDate: 2024-12-12 16:29:45 +0000 >> Commit: Andrew Turner <andrew@FreeBSD.org> >> CommitDate: 2024-12-12 18:00:22 +0000 >> >> acpica: Extract _OSC parsing to a common file >> This will be used by pci_host_generic_acpi.c so needs to be = >> in a >> common location. >> Reviewed by: imp, jhb >> Sponsored by: Arm Ltd >> Differential Revision: https://reviews.freebsd.org/D48044 > > My dev system was running CURRENT from Oct 31 and broke after I = > upgrade to most recent version on Dec 20. After bisecting I found = > this commit as the one that introduced the problem. > > It starts booting but can't found any disk. Pressing ? at mount = > prompt shows nothing. This system is a VM running on KVM and I've = > attached dmesg from successfully boot > > FreeBSD idaho.arrakis.com.br 15.0-CURRENT FreeBSD 15.0-CURRENT #22 = > n274182-938e4b131c4: Thu Dec 26 18:10:12 -03 2024 = > root@idaho.arrakis.com.br:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODE= BUG = > amd64 > I=E2=80=99m seeing similar boot issues on VMWare aarch64 (i.e. freebsd in= = VMware on a Mac). My bisect pointed to: commit 1f5c50a8617355758510675cb9412f56fed12efc Author: Andrew Turner <andrew@FreeBSD.org> Date: Thu Dec 12 16:30:39 2024 +0000 pci_host_generic:Add pcib_request_feature on ACPI In the ACPI attachment add support for the pcib_request_feature = method. This uses the common _OSC handling. Reviewed by: imp, jhb Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D48048 I=E2=80=99ve not yet been able to capture a dmesg, but it looks like the = nvme = storage device just isn=E2=80=99t found, leading to the zpool failing to = mount. I=E2=80=99m currently working around that with this patch: diff --git a/sys/dev/pci/pci_host_generic_acpi.c = b/sys/dev/pci/pci_host_generic_acpi.c index 1ff3a6bda707..c990edf26a3c 100644 --- a/sys/dev/pci/pci_host_generic_acpi.c +++ b/sys/dev/pci/pci_host_generic_acpi.c @@ -543,7 +543,7 @@ static device_method_t generic_pcie_acpi_methods[] = =3D { DEVMETHOD(pcib_release_msix, = generic_pcie_acpi_release_msix), DEVMETHOD(pcib_map_msi, generic_pcie_acpi_map_msi), DEVMETHOD(pcib_get_id, generic_pcie_acpi_get_id), - DEVMETHOD(pcib_request_feature, = generic_pcie_acpi_request_feature), + //DEVMETHOD(pcib_request_feature, = generic_pcie_acpi_request_feature), DEVMETHOD_END }; Best regards, Kristof --=_MailMate_B90DBFDC-A7D8-4764-961A-A5BB375C1A68_= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html> <html> <head> <meta http-equiv=3D"Content-Type" content=3D"text/xhtml; charset=3Dutf-8"= > </head> <body><div style=3D"font-family: sans-serif;"><div class=3D"markdown" sty= le=3D"white-space: normal;"> <p dir=3D"auto">On 26 Dec 2024, at 21:44, Renato Botelho wrote:</p> <blockquote style=3D"margin: 0 0 5px; padding-left: 5px; border-left: 2px= solid #136BCE; color: #136BCE;"> <p dir=3D"auto">On 12/12/24 15:19, Andrew Turner wrote:</p> <blockquote style=3D"margin: 0 0 5px; padding-left: 5px; border-left: 2px= solid #136BCE; border-left-color: #4B89CF; color: #4B89CF;"> <p dir=3D"auto">The branch main has been updated by andrew:</p> <p dir=3D"auto">URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D= ba1904937d9ae0539e39001467a1519b17177118">https://cgit.FreeBSD.org/src/co= mmit/?id=3Dba1904937d9ae0539e39001467a1519b17177118</a></p> <p dir=3D"auto">commit ba1904937d9ae0539e39001467a1519b17177118<br> Author: Andrew Turner <a href=3D"mailto:andrew@FreeBSD.org">andrew@Fr= eeBSD.org</a><br> AuthorDate: 2024-12-12 16:29:45 +0000<br> Commit: Andrew Turner <a href=3D"mailto:andrew@FreeBSD.org">andrew@Fr= eeBSD.org</a><br> CommitDate: 2024-12-12 18:00:22 +0000</p> <pre style=3D"margin-left: 15px; margin-right: 15px; padding: 5px; border= : thin solid gray; overflow-x: auto; max-width: 90vw; background-color: #= E4E4E4;"><code style=3D"padding: 0 0.25em; background-color: #E4E4E4;"> a= cpica: Extract _OSC parsing to a common file This will be used by pci_host_generic_acpi.c so needs to be in a common location. Reviewed by: imp, jhb Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D48044 </code></pre> </blockquote> <p dir=3D"auto">My dev system was running CURRENT from Oct 31 and broke a= fter I upgrade to most recent version on Dec 20. After bisecting I found= this commit as the one that introduced the problem.</p> <p dir=3D"auto">It starts booting but can't found any disk. Pressing ? a= t mount prompt shows nothing. This system is a VM running on KVM and I'v= e attached dmesg from successfully boot</p> <p dir=3D"auto">FreeBSD idaho.arrakis.com.br 15.0-CURRENT FreeBSD 15.0-CU= RRENT #22 n274182-938e4b131c4: Thu Dec 26 18:10:12 -03 2024 <a href=3D"ma= ilto:root@idaho.arrakis.com.br">root@idaho.arrakis.com.br</a>:/usr/obj/us= r/src/amd64.amd64/sys/GENERIC-NODEBUG amd64</p> </blockquote> <p dir=3D"auto">I=E2=80=99m seeing similar boot issues on VMWare aarch64 = (i.e. freebsd in VMware on a Mac). My bisect pointed to:</p> <pre style=3D"margin-left: 15px; margin-right: 15px; padding: 5px; border= : thin solid gray; overflow-x: auto; max-width: 90vw; background-color: #= E4E4E4;"><code style=3D"padding: 0 0.25em; background-color: #E4E4E4;">co= mmit 1f5c50a8617355758510675cb9412f56fed12efc Author: Andrew Turner <andrew@FreeBSD.org> Date: Thu Dec 12 16:30:39 2024 +0000 pci_host_generic:Add pcib_request_feature on ACPI In the ACPI attachment add support for the pcib_request_feature metho= d. This uses the common _OSC handling. Reviewed by: imp, jhb Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D48048 </code></pre> <p dir=3D"auto">I=E2=80=99ve not yet been able to capture a dmesg, but it= looks like the nvme storage device just isn=E2=80=99t found, leading to = the zpool failing to mount.</p> <p dir=3D"auto">I=E2=80=99m currently working around that with this patch= :</p> <pre style=3D"margin-left: 15px; margin-right: 15px; padding: 5px; border= : thin solid gray; overflow-x: auto; max-width: 90vw; background-color: #= E4E4E4;"><code style=3D"padding: 0 0.25em; background-color: #E4E4E4;">di= ff --git a/sys/dev/pci/pci_host_generic_acpi.c b/sys/dev/pci/pci_host_gen= eric_acpi.c index 1ff3a6bda707..c990edf26a3c 100644 --- a/sys/dev/pci/pci_host_generic_acpi.c +++ b/sys/dev/pci/pci_host_generic_acpi.c @@ -543,7 +543,7 @@ static device_method_t generic_pcie_acpi_methods[] =3D= { DEVMETHOD(pcib_release_msix, generic_pcie_acpi_release_msix), DEVMETHOD(pcib_map_msi, generic_pcie_acpi_map_msi), DEVMETHOD(pcib_get_id, generic_pcie_acpi_get_id), - DEVMETHOD(pcib_request_feature, generic_pcie_acpi_request_feature= ), + //DEVMETHOD(pcib_request_feature, generic_pcie_acpi_request= _feature), DEVMETHOD_END }; </code></pre> <p dir=3D"auto">Best regards,<br> Kristof</p> </div> </div> </body> </html> --=_MailMate_B90DBFDC-A7D8-4764-961A-A5BB375C1A68_=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AC5C158F-085B-468F-A3C8-1B56524438C9>