From owner-freebsd-net@FreeBSD.ORG  Tue Nov  3 13:00:10 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CA35B1065693
	for <freebsd-net@hub.freebsd.org>; Tue,  3 Nov 2009 13:00:10 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 968708FC1E
	for <freebsd-net@hub.freebsd.org>; Tue,  3 Nov 2009 13:00:10 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nA3D0Ajk019033
	for <freebsd-net@freefall.freebsd.org>; Tue, 3 Nov 2009 13:00:10 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nA3D0AF5019032;
	Tue, 3 Nov 2009 13:00:10 GMT (envelope-from gnats)
Date: Tue, 3 Nov 2009 13:00:10 GMT
Message-Id: <200911031300.nA3D0AF5019032@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/138999: commit references a PR
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Nov 2009 13:00:10 -0000

The following reply was made to PR kern/138999; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/138999: commit references a PR
Date: Tue,  3 Nov 2009 12:52:49 +0000 (UTC)

 Author: kib
 Date: Tue Nov  3 12:52:35 2009
 New Revision: 198853
 URL: http://svn.freebsd.org/changeset/base/198853
 
 Log:
   If socket buffer space appears to be lower then sum of count of already
   prepared bytes and next portion of transfer, inner loop of kern_sendfile()
   aborts, not preparing next mbuf for socket buffer, and not modifying
   any outer loop invariants. The thread loops in the outer loop forever.
   
   Instead of breaking from inner loop, prepare only bytes that fit into
   the socket buffer space.
   
   In collaboration with:	pho
   Reviewed by:	bz
   PR:	kern/138999
   MFC after:	2 weeks
 
 Modified:
   head/sys/kern/uipc_syscalls.c
 
 Modified: head/sys/kern/uipc_syscalls.c
 ==============================================================================
 --- head/sys/kern/uipc_syscalls.c	Tue Nov  3 12:03:13 2009	(r198852)
 +++ head/sys/kern/uipc_syscalls.c	Tue Nov  3 12:52:35 2009	(r198853)
 @@ -2037,20 +2037,12 @@ retry_space:
  				rem = obj->un_pager.vnp.vnp_size -
  				    uap->offset - fsbytes - loopbytes;
  			xfsize = omin(rem, xfsize);
 +			xfsize = omin(space - loopbytes, xfsize);
  			if (xfsize <= 0) {
  				VM_OBJECT_UNLOCK(obj);
  				done = 1;		/* all data sent */
  				break;
  			}
 -			/*
 -			 * Don't overflow the send buffer.
 -			 * Stop here and send out what we've
 -			 * already got.
 -			 */
 -			if (space < loopbytes + xfsize) {
 -				VM_OBJECT_UNLOCK(obj);
 -				break;
 -			}
  
  			/*
  			 * Attempt to look up the page.  Allocate
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"