From owner-freebsd-ports-bugs@freebsd.org Thu Sep 7 11:34:58 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58F74E196C1 for ; Thu, 7 Sep 2017 11:34:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 074FA779EB for ; Thu, 7 Sep 2017 11:34:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v87BYuXK031925 for ; Thu, 7 Sep 2017 11:34:57 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 222122] mail/opendkim rc script needs default for $milteropendkim_socket Date: Thu, 07 Sep 2017 11:34:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: thomas@gibfest.dk X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2017 11:34:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222122 Bug ID: 222122 Summary: mail/opendkim rc script needs default for $milteropendkim_socket Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: thomas@gibfest.dk CC: freebsd-ports@dan.me.uk Flags: maintainer-feedback?(freebsd-ports@dan.me.uk) CC: freebsd-ports@dan.me.uk Since ports r448274 the rc.d script for milter-opendkim outputs an error wh= en I do not have $milteropendkim_socket set in rc.conf but have it set in the co= nfig file. The latest change to the rc.d script appears to assume that $milteropendkim_socket is always set. I think a default is needed or the test in line 77 needs to check if anythi= ng is in the $milteropendkim_socket variable. test(1) returns true (exit code = 0) when given no args. Below is the output from starting milter-opendkim without setting $milteropendkim_socket in rc.conf with rc_debug enabled: [tsr@smtp2 ~]$ sudo service milter-opendkim start /usr/local/etc/rc.d/milter-opendkim: DEBUG: pid file (/var/run/milteropendkim/pid): not readable. /usr/local/etc/rc.d/milter-opendkim: DEBUG: checkyesno: milteropendkim_enab= le is set to yes. /usr/local/etc/rc.d/milter-opendkim: DEBUG: run_rc_command: start_precmd: dkim_prepcmd=20 Starting milteropendkim. /usr/local/etc/rc.d/milter-opendkim: DEBUG: run_rc_command: doit: limits -C daemon /usr/local/sbin/opendkim -l -u postfix:mailnull -P /var/run/milteropendkim/pid -x /usr/local/etc/opendkim.conf=20=20=20=20 /usr/local/etc/rc.d/milter-opendkim: DEBUG: run_rc_command: start_postcmd: dkim_start_postcmd=20 usage: chmod [-fhv] [-R [-H | -L | -P]] mode file ... [tsr@smtp2 ~]$=20 Below is the output from starting milter-opendkim with $milteropendkim_sock= et set in rc.conf with rc_debug enabled: [tsr@smtp2 ~]$ sudo service milter-opendkim start /usr/local/etc/rc.d/milter-opendkim: DEBUG: pid file (/var/run/milteropendkim/pid): not readable. /usr/local/etc/rc.d/milter-opendkim: DEBUG: checkyesno: milteropendkim_enab= le is set to yes. /usr/local/etc/rc.d/milter-opendkim: DEBUG: run_rc_command: start_precmd: dkim_prepcmd=20 Starting milteropendkim. /usr/local/etc/rc.d/milter-opendkim: DEBUG: run_rc_command: doit: limits -C daemon /usr/local/sbin/opendkim -l -p local:/var/spool/postfix/opendkim/opendkim.sock -u postfix:mailnull -P /var/run/milteropendkim/pid -x /usr/local/etc/opendkim.conf=20=20=20=20 /usr/local/etc/rc.d/milter-opendkim: DEBUG: run_rc_command: start_postcmd: dkim_start_postcmd=20 [tsr@smtp2 ~]$ --=20 You are receiving this mail because: You are the assignee for the bug.=