From owner-svn-src-all@freebsd.org Tue Apr 25 19:07:24 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 62EDDD50ED2; Tue, 25 Apr 2017 19:07:24 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3665ECBB; Tue, 25 Apr 2017 19:07:24 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v3PJ7MTs062850; Tue, 25 Apr 2017 12:07:22 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v3PJ7Mxv062849; Tue, 25 Apr 2017 12:07:22 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201704251907.v3PJ7Mxv062849@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r317409 - head/contrib/tcpdump In-Reply-To: To: Benjamin Kaduk Date: Tue, 25 Apr 2017 12:07:22 -0700 (PDT) CC: rgrimes@freebsd.org, Gleb Smirnoff , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 19:07:24 -0000 [ Charset UTF-8 unsupported, converting... ] > On Tue, Apr 25, 2017 at 1:30 PM, Rodney W. Grimes < > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > [ Charset UTF-8 unsupported, converting... ] > > > Author: glebius > > > Date: Tue Apr 25 15:56:46 2017 > > > New Revision: 317409 > > > URL: https://svnweb.freebsd.org/changeset/base/317409 > > > > > > Log: > > > Cherry-pick 5d3c5151c2b885aab36627bafb8539238da27b2d, it fixes use > > after free > > > > Lets not use git hashes as references in commit messages, > > it has very little value for someone reading a log of changes > > looking for something. There is no promise that it can be > > found later (github can go Poof). > > > > On the contrary, a git SHA1 seems like an eminently stable and unique > search parameter! > I agree that a commit log should inline some summary of the change as well > as provide a > link to the external source, but I am not worried that a future reader will > be unable to find > the referenced commit. There is no administrative policy in place that says github users shall maintain there history. I had too many indirections to find this change on github: commitlog -> google -> wrong article that references this sha1 -> actual commit I re-iterate lets NOT start to use git hashes in our commit messages. -- Rod Grimes rgrimes@freebsd.org