From owner-svn-src-head@FreeBSD.ORG Thu Nov 12 18:50:50 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 13034106568F; Thu, 12 Nov 2009 18:50:50 +0000 (UTC) (envelope-from flo@smeets.im) Received: from mail.solomo.de (mail.solomo.de [85.214.49.72]) by mx1.freebsd.org (Postfix) with ESMTP id B94788FC12; Thu, 12 Nov 2009 18:50:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.solomo.de (Postfix) with ESMTP id 90C6C3F499; Thu, 12 Nov 2009 19:50:48 +0100 (CET) X-Virus-Scanned: amavisd-new at vistream.de Received: from mail.solomo.de ([127.0.0.1]) by localhost (mail.solomo.de [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qTt1IKLPGtJL; Thu, 12 Nov 2009 19:50:46 +0100 (CET) Received: from [192.168.0.113] (p50916A71.dip.t-dialin.net [80.145.106.113]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.solomo.de (Postfix) with ESMTPSA id D4EB23F44F; Thu, 12 Nov 2009 19:50:45 +0100 (CET) Message-ID: <4AFC5905.70101@smeets.im> Date: Thu, 12 Nov 2009 19:50:45 +0100 From: Florian Smeets User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.5) Gecko/20091112 Lightning/1.0pre Shredder/3.0pre MIME-Version: 1.0 To: Kostik Belousov References: <7meio5g4yx.wl%kuriyama@s2factory.co.jp> <20091111215651.GM64905@hoeg.nl> <20091111223340.GF2331@deviant.kiev.zoral.com.ua> <20091112145506.GH2331@deviant.kiev.zoral.com.ua> In-Reply-To: <20091112145506.GH2331@deviant.kiev.zoral.com.ua> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, Ed Schouten , svn-src-all@freebsd.org, src-committers@freebsd.org, Jun Kuriyama Subject: Re: svn commit: r199067 - in head/sys: amd64/amd64 i386/i386 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2009 18:50:50 -0000 On 11/12/09 3:55 PM, Kostik Belousov wrote: > On Thu, Nov 12, 2009 at 12:33:40AM +0200, Kostik Belousov wrote: >> On Wed, Nov 11, 2009 at 10:56:51PM +0100, Ed Schouten wrote: >>> Hi, >>> >>> * Jun Kuriyama wrote: >>>> Can you test with these patches? Testing on only one of both system >>>> is enough. "patch-1" forces disabling CLFLUSH feature even if SS bit >>>> exists. "patch-2" forces no CLFLUSH tweak. I'd like to know with >>>> which patch your system can live. >>> >>> For some reason they both seem to boot. Yikes. I've done some more >>> testing and it seems the old version even hangs if I add some additional >>> printf's above and below, which makes me believe the problem is a bit >>> more complex than we realize... >> >> The only thing I see now is that TUNABLE_INT declaration is not needed, >> since SYSINIT is started after hammer_time(), so TUNABLE_FETCH is >> processed after everything is done for BSP. >> >> Wait, are your machines SMP ? Hmm, could you, please, remove TUNABLE_INT() >> and see how it ends up ? > > [Selecting random email in the thread]. > > Luckily, my co-worker has laptop that runs HEAD and exhibited the > problem. Patch below fixed the hang for him. Will be happy to get > confirmation that patch fixes the hung for other people who reported it. > > http://people.freebsd.org/~kib/misc/initcache.1.patch > > Issue is that TUNABLE_INT_FETCH was called on AP while CPU was not > initialized properly, in particular, curthread was not set etc. But, > kernel environment is already switched to dynamic, so access needs to > lock a mutex. > > I am currently looking at i386, that probably needs similar change. > r199229 + your patch boots again. Thank you very much! Cheers, Florian