From owner-freebsd-eclipse@FreeBSD.ORG  Mon Oct 10 16:10:21 2005
Return-Path: <owner-freebsd-eclipse@FreeBSD.ORG>
X-Original-To: freebsd-eclipse@hub.freebsd.org
Delivered-To: freebsd-eclipse@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 88AD516A41F
	for <freebsd-eclipse@hub.freebsd.org>;
	Mon, 10 Oct 2005 16:10:21 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5922D43D45
	for <freebsd-eclipse@hub.freebsd.org>;
	Mon, 10 Oct 2005 16:10:21 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j9AGALxK002441
	for <freebsd-eclipse@freefall.freebsd.org>;
	Mon, 10 Oct 2005 16:10:21 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j9AGALDD002440;
	Mon, 10 Oct 2005 16:10:21 GMT (envelope-from gnats)
Date: Mon, 10 Oct 2005 16:10:21 GMT
Message-Id: <200510101610.j9AGALDD002440@freefall.freebsd.org>
To: freebsd-eclipse@FreeBSD.org
From: Panagiotis Astithas <past@ebs.gr>
Cc: 
Subject: Re: ports/86860: [patch] Align java/eclipse invocation with
	javavmwrapper
X-BeenThere: freebsd-eclipse@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Panagiotis Astithas <past@ebs.gr>
List-Id: "FreeBSD users of eclipse EDI, tools, rich client apps &amp;
	ports." <freebsd-eclipse.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-eclipse>, 
	<mailto:freebsd-eclipse-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-eclipse>
List-Post: <mailto:freebsd-eclipse@freebsd.org>
List-Help: <mailto:freebsd-eclipse-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-eclipse>,
	<mailto:freebsd-eclipse-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Oct 2005 16:10:21 -0000

The following reply was made to PR ports/86860; it has been noted by GNATS.

From: Panagiotis Astithas <past@ebs.gr>
To: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/86860: [patch] Align java/eclipse invocation with javavmwrapper
Date: Mon, 10 Oct 2005 19:02:52 +0300

 Herve Quiroz wrote:
 > Hi,
 > 
 > I am a bit late on this topic (PR already closed) but I just noticed a
 > flaw with this change.
 > 
 > javavmwrapper picks a JDK depending on several variables -- see
 > javavm(1). With this change it is possible that a not suitable JDK gets
 > picked up. Here is a patch that should fix this (I didn't test it
 > though).
 > 
 > 
 > Index: files/eclipse.in
 > ===================================================================
 > RCS file: /home/ncvs/ports/java/eclipse/files/eclipse.in,v
 > retrieving revision 1.5
 > diff -u -r1.5 eclipse.in
 > --- files/eclipse.in	9 Oct 2005 14:54:21 -0000	1.5
 > +++ files/eclipse.in	10 Oct 2005 14:54:13 -0000
 > @@ -46,4 +46,4 @@
 >  	exit 1
 >  fi
 >  
 > -PATH=${JAVA_HOME}/bin:$PATH exec "${ECLIPSE_HOME}/eclipse" $@
 > +JAVA_VERSION="%%JAVA_VERSION%%" JAVA_OS="%%JAVA_OS%%" PATH=${JAVA_HOME}/bin:$PATH exec "${ECLIPSE_HOME}/eclipse" $@
 
 Why do you think this is necessary? What the eclipse executable does is 
 invoke the java executable it finds in the PATH. Since we have made sure 
 the javavmwrapper's symlink will get chosen as the default, it will 
 honour the JAVA_VERSION and JAVA_OS variables, right? Am I missing 
 something here?
 
 Regards,
 
 Panagiotis