From nobody Sun Jul 31 05:42:44 2022 X-Original-To: freebsd-arch@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LwVXC5Wznz4Y66g for ; Sun, 31 Jul 2022 05:42:51 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LwVXC4phXz3w2c; Sun, 31 Jul 2022 05:42:51 +0000 (UTC) (envelope-from se@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659246171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SlEjzxNdkJ6N6fcwtBwkLzhw5CfNuthq2T29/9CJ01I=; b=cpoPDTAP1T+KWrmzR+aQbkiGvhOXwQXE4jqSPtezny0W4MJIT+7k1q4dZeyKHr6KKSTCoU WiwZU/CEGPUwSf7xM7wEcdrQ0+iV4AminDottiVPggrc5/sy27Hj8USURYRT7iv7GDxs9I DYt7H4aMv/NrxUJCH3q3ULCZ6q9lSKryGo/cx4z/MqIcZBox5VOaJelDKuqlr33UdkMHqE MTyff+OUyFNdz5WNBxSZQYL9DZ1qLL5M6BSwKVHe15KarCyeUZGncZTx+Ybdh4WyFAbWab d7fAs2cP1VQ3qpPRjv14/GUI+3CjmDLT6MkQvlWYoVhlQdE2kQXwJ7L3/jyvkg== Received: from [IPV6:2003:cd:5f1a:d900:cdf0:14fa:b3bf:f33d] (p200300cd5f1ad900cdf014fab3bff33d.dip0.t-ipconnect.de [IPv6:2003:cd:5f1a:d900:cdf0:14fa:b3bf:f33d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4LwVXC0nNWzTN4; Sun, 31 Jul 2022 05:42:50 +0000 (UTC) (envelope-from se@FreeBSD.org) Message-ID: Date: Sun, 31 Jul 2022 07:42:44 +0200 List-Id: Discussion related to FreeBSD architecture List-Archive: https://lists.freebsd.org/archives/freebsd-arch List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arch@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.0 Subject: Re: Style(9): Allow // comments Content-Language: de-DE, en-US To: "Julian H. Stacey" References: <202207302325.26UNP8Dl028217@lapr.no.berklix.net> From: Stefan Esser Cc: "freebsd-arch@freebsd.org" In-Reply-To: <202207302325.26UNP8Dl028217@lapr.no.berklix.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659246171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SlEjzxNdkJ6N6fcwtBwkLzhw5CfNuthq2T29/9CJ01I=; b=unAuv2mSVf714i3kPfbiSgIHzhm/dQ84jbHLnrjUnU0MZcewdNUuAMrePZ4Dl77KKLF9/6 pcjMrpptUpccSg26N7MSG8JD7Ds8vgzxa2HopKgakZzQeQFF5mI8tOEESi0FC9JUvI5sfp t7UnveeNCDvld1BXY7haLkGsEiKMNPRwREg88zyFKAVXKudzkKJvqnF3FKiBHS8BoxO/Kc qJayDpcuFB4DpLNlXfSaUKSLVYKZteBQ3MpFNKmp+Lo7mot1J5O3LcuoAWAzC+3TRrlnld lmUn9mv7VoqACWUeSIiwhooIDQ5oKxYzyC7M1vqkIKO6pC99lLeK/B1DPs5g4A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1659246171; a=rsa-sha256; cv=none; b=lAQvLgRIypzQc8CLJyYKQqGoTUCPslUAF4yZCBCBAgbJmyaW0afFPFpkUKJjlG6/uWOHdl TnBH1zGhw3ZyrSlJal5dkQKRUhjs9PiRPq32wph1pAoscZoDTE4w5CVp38YqbrMZ4vEIiV cTZNP5pKRNuK59JRj28ev/xQgOSlirKXECDF7bzfXAkvMNvZM06ITPQei8wqShQ2OUQ0wB PsTfoVBrJAwri0bTYcCpX3HFV7zC5Y2grsa/NEInAEFAnlOl++AC9znyT9CkhfhU3F+Df2 XJ6uEbIt8SlMq7p4xovgOpZ0WKPuWmWIwExlXStx6bUamBlPT9TWGi9lqjmBFQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Am 31.07.22 um 01:25 schrieb Julian H. Stacey: > Beware // as a delimeter in calendar files, exaples below. > Nov 5 Fireworks in UK https://en.wikipedia.org/wiki/Guy_Fawkes_Night > > I have 248 lines match on > http://berklix.com/~jhs/src/bsd/fixes/freebsd/src/gen/usr.bin/calendar/ > find . -type f | xargs grep // | grep http | grep -v /no_customise/ | wc -l > > Most http[s]:// are in commented out blocks, but some are uncommented, eg: > > Oct Sun-1 Munich Oktoberfest ends http://www.oktoberfest.de > /* Not sure if exact algorithm, probably first Sun. in Oct, > * but might be Sunday of 1st full weekend in Oct? > * I've kept a log to later deduce, see > * http://www.berklix.com/~jhs/src/bsd/fixes/freebsd/src/gen/usr.bin/calendar/calendars/de_DE.ISO8859-1/bavaria/munich/calendar.other > * Start date is more problematic, being > * Saturday with 16 days to end on Sunday. > * & Parade as Friday with 17 days before end, > * An easter-16 type fuctionality would be nice. > */ I am not sure what you are trying to say with your comment ... For one thing, calendar files are not C source code, which is the subject of the proposed change to allow C++ style single line commends. And I did not see any issues with the use of // in URLs in calendar files in my testing. I had extended the parsing of calendar files to reintroduce conditional sections, definitions, and comments as previously implemented by processing by the traditional C preprocessor, and I have been waiting for your feedback on whether these features work correctly. The calendar program treats // as the start of a comment only at the beginning of a line or if it follows white space. This detail was missing in the calendar man page and I have just added it on -CURRENT. Please let me know if calendar files are not parsed as expected and as documented. Regards, STefan