From owner-freebsd-current Fri Jun 7 21:52:19 2002 Delivered-To: freebsd-current@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 931) id 2F31837B403; Fri, 7 Jun 2002 21:52:15 -0700 (PDT) Date: Fri, 7 Jun 2002 21:52:15 -0700 From: "J. Mallett" To: "Steven G. Kargl" Cc: freebsd-current@FreeBSD.ORG Subject: Re: patches for [x]install Message-ID: <20020607215214.A28624@FreeBSD.ORG> References: <20020607214350.A25230@FreeBSD.ORG> <200206080448.g584mZvv068978@troutmask.apl.washington.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200206080448.g584mZvv068978@troutmask.apl.washington.edu>; from kargl@troutmask.apl.washington.edu on Fri, Jun 07, 2002 at 09:48:35PM -0700 Organisation: The FreeBSD Project X-Alternate-Addresses: , , , X-Affiliated-Projects: FreeBSD, xMach, ircd-hybrid-7 X-Towel: Yes Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * From "Steven G. Kargl" > J. Mallett said: > > * From "Steven G. Kargl" > > > The first patch fixes install(1). The reamining patches > > > correctly document the breakage of rev 1.55 of xinstall.c > > I should have stated that if the first patch isn't > acceptable, then the remaining patches should be > applied. > > > > > The last patch is wrong, the others are good, though a warning about the > > overriding of flags might be nice until this is ACCEPTED behaviour by the > > user community. > > > > The third patch is wrong because there are things other than -C that one > > might want to override INSTALL with, for example an INSTALL that uses a > > replacement program that static relinks an executable being installed > > to a partition where its dynamic dependencies are not satisfied. > > No. The third patch is correct (see below); otherwise I could set > INSTALL to " install -C" QED. And I could set BINOWN to something bogus. Don't protect the user by removing functionality. -- J. Mallett FreeBSD: The Power To Serve "I've coined new words, like, misunderstanding and Hispanically." -- George W. Bush, Radio-Television Correspondents Association dinner, Washington, D.C., March 29, 2001 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message