Date: Thu, 25 Sep 1997 10:20:08 +0800 From: Peter Wemm <peter@netplex.com.au> To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru> Cc: Julian Elischer <julian@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-include@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, cvs-usrbin@FreeBSD.ORG Subject: Re: cvs commit: src/include ctype.h src/lib/libc/db/man Makefile.inc src/lib/libc/locale mskanji.c Makefile.inc isctype.c setrunelocale.c src/usr.bin/mklocale/data ja_JP.SJIS.src Makefile Message-ID: <199709250220.KAA01317@spinner.netplex.com.au> In-Reply-To: Your message of "Thu, 25 Sep 1997 01:57:10 %2B0400." <Pine.BSF.3.96.970925015330.25107A-100000@lsd.relcom.eu.net>
next in thread | previous in thread | raw e-mail | index | archive | help
=?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= wrote:
> On Wed, 24 Sep 1997, Julian Elischer wrote:
>
> > lib/libc/locale Makefile.inc isctype.c setrunelocale.c
>
> MSKanji should be moved under XPG4 define (like EUC) since our libc is not
> yet 16bit clean. Setting LANG to MSKanji will cause great damage for all
> non-X11 programs - it was the reason why separate library was created -
> only for programs which are 16bit aware, not for standard 8bit programs.
> Please fix or let me.
Not only that, but this commit breaks the build!! After rebuilding
includes (and triple checking), the ctype.h file preprocesses as:
static __inline int
__maskrune(_BSD_RUNE_T_ c, unsigned long f)
{
return(((c & (~((1 <<8 ) - 1)) )
? ___runetype(c) : _CurrentRuneLocale->runetype[c]) & f);
}
from (at least) usr.bin/systat/cmds.c.
cmds.c #includes the following in this order:
#include <stdlib.h>
#include <unistd.h>
#include <signal.h>
#include <ctype.h>
I suspect this happens because of:
#ifdef _BSD_RUNE_T_
typedef _BSD_RUNE_T_ rune_t;
#undef _BSD_RUNE_T_
^^^^^^^^^^^^^^^^^^^^
#endif
#endif
and _BSD_RUNE_T_ is used explicitly in ctype.h.. It was #defined once in
<machine/ansi.h> but won't be redefined again a second time due to the
multiple include protection.
Cheers,
-Peter
--
Peter Wemm <peter@netplex.com.au> Netplex Consulting
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199709250220.KAA01317>