From owner-svn-src-all@FreeBSD.ORG Tue Jun 23 06:56:14 2015 Return-Path: Delivered-To: svn-src-all@nevdull.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7DDC4D16; Tue, 23 Jun 2015 06:56:14 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 579042E5; Tue, 23 Jun 2015 06:56:14 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from [10.239.242.219] (unknown [166.170.31.47]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id A107EB91F; Tue, 23 Jun 2015 02:56:12 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r284706 - stable/10/sys/dev/ixl From: John Baldwin X-Mailer: iPhone Mail (12F70) In-Reply-To: <201506221937.t5MJb5wt059430@svn.freebsd.org> Date: Tue, 23 Jun 2015 02:56:10 -0400 Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-stable@freebsd.org" , "svn-src-stable-10@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <31922418-6DDC-4AA5-BF92-5E1C9075D00F@FreeBSD.org> References: <201506221937.t5MJb5wt059430@svn.freebsd.org> To: Andrew Gallatin X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 23 Jun 2015 02:56:12 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2015 06:56:14 -0000 I think you have to use if_initbaudrate() in 10 (maybe 9 as well?) instead o= f a direct assignment since if_baudrate is only a long (and thus 32-bit on 3= 2-bit platforms). We use an extra scaling variable in older branches to all= ow higher baud rates to be represented. --=20 John Baldwin > On Jun 22, 2015, at 15:37, Andrew Gallatin wrote: >=20 > Author: gallatin > Date: Mon Jun 22 19:37:04 2015 > New Revision: 284706 > URL: https://svnweb.freebsd.org/changeset/base/284706 >=20 > Log: > MFC r284612: Fix a typo >=20 > Sponsored by: Netflix >=20 > Modified: > stable/10/sys/dev/ixl/if_ixl.c > Directory Properties: > stable/10/ (props changed) >=20 > Modified: stable/10/sys/dev/ixl/if_ixl.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- stable/10/sys/dev/ixl/if_ixl.c Mon Jun 22 19:01:09 2015 (r284705= ) > +++ stable/10/sys/dev/ixl/if_ixl.c Mon Jun 22 19:37:04 2015 (r284706= ) > @@ -2324,7 +2324,7 @@ ixl_setup_interface(device_t dev, struct > } > if_initname(ifp, device_get_name(dev), device_get_unit(dev)); > ifp->if_mtu =3D ETHERMTU; > - ifp->if_baudrate =3D 4000000000; // ?? > + ifp->if_baudrate =3D IF_Gbps(40); > ifp->if_init =3D ixl_init; > ifp->if_softc =3D vsi; > ifp->if_flags =3D IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST; >=20