From owner-freebsd-current@FreeBSD.ORG  Wed Jun 27 08:16:52 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D0CDE16A468;
	Wed, 27 Jun 2007 08:16:52 +0000 (UTC) (envelope-from dfr@rabson.org)
Received: from itchy.rabson.org (mailgate.nlsystems.com [80.177.232.242])
	by mx1.freebsd.org (Postfix) with ESMTP id 86F8113C4BA;
	Wed, 27 Jun 2007 08:16:52 +0000 (UTC) (envelope-from dfr@rabson.org)
Received: from herring.rabson.org (herring.rabson.org [80.177.232.250])
	by itchy.rabson.org (8.13.3/8.13.3) with ESMTP id l5R7bTJr031915;
	Wed, 27 Jun 2007 08:37:29 +0100 (BST) (envelope-from dfr@rabson.org)
From: Doug Rabson <dfr@rabson.org>
To: Pawel Jakub Dawidek <pjd@freebsd.org>
Date: Wed, 27 Jun 2007 08:37:27 +0100
User-Agent: KMail/1.9.6
References: <46813AF4.4020004@crc.u-strasbg.fr>
	<C465AD69-BA88-4B02-90FA-AF8A70742F3B@rabson.org>
	<20070627070618.GC21749@garage.freebsd.pl>
In-Reply-To: <20070627070618.GC21749@garage.freebsd.pl>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-6"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200706270837.28175.dfr@rabson.org>
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY 
	autolearn=failed version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on itchy.rabson.org
X-Virus-Scanned: ClamAV 0.87.1/3540/Wed Jun 27 03:54:27 2007 on
	itchy.rabson.org
X-Virus-Status: Clean
Cc: Philippe Pegon <Philippe.Pegon@crc.u-strasbg.fr>, current@freebsd.org
Subject: Re: nfs on zfs panic
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jun 2007 08:16:52 -0000

On Wednesday 27 June 2007, Pawel Jakub Dawidek wrote:
> On Tue, Jun 26, 2007 at 06:10:44PM +0100, Doug Rabson wrote:
> > It looks like nvp is NULL at the point where it crashed. Looking at
> > the zfs code, zfs_vget always returns zero, even if it failed to
> > find a vnode which matches the given 'inode' number. Try changing
> > the return statement in zfs_vget from 'return (0)' to 'return
> > (err)'.
>
> Your analysis is correct, can you commit this?

I tried to commit it but got the 'need Approved by: re' message. Do you 
have blanket re approval for this stuff?