From owner-freebsd-arch@FreeBSD.ORG Sat Aug 18 23:10:22 2007 Return-Path: Delivered-To: freebsd-arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9955716A419 for ; Sat, 18 Aug 2007 23:10:22 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id 34A1813C47E for ; Sat, 18 Aug 2007 23:10:21 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 54FAC45CD9; Sun, 19 Aug 2007 01:10:20 +0200 (CEST) Received: from localhost (154.81.datacomsa.pl [195.34.81.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id D3EAB45684 for ; Sun, 19 Aug 2007 01:10:14 +0200 (CEST) Date: Sun, 19 Aug 2007 01:09:17 +0200 From: Pawel Jakub Dawidek To: freebsd-arch@FreeBSD.org Message-ID: <20070818230917.GI6498@garage.freebsd.pl> References: <20070818120056.GA6498@garage.freebsd.pl> <20070818220756.GH6498@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Li7ckgedzMh1NgdW" Content-Disposition: inline In-Reply-To: <20070818220756.GH6498@garage.freebsd.pl> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00 autolearn=ham version=3.0.4 Cc: Subject: Re: Lockless uidinfo. X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Aug 2007 23:10:22 -0000 --Li7ckgedzMh1NgdW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 19, 2007 at 12:07:56AM +0200, Pawel Jakub Dawidek wrote: > Two more things... >=20 > > The patch below remove per-uidinfo locks: > >=20 > > http://people.freebsd.org/~pjd/patches/uidinfo_lockless.patch >=20 > We could upgrade from lock-free algorithm I used here to wait-free > algorithm, but we don't have atomic_fetchadd_long(). How hard will it be > to implement it? >=20 > We could then change: >=20 > do { > old =3D uip->ui_proccnt; > if (old + diff > max) > return (0); > } while (atomic_cmpset_long(&uip->ui_proccnt, old, old + diff) =3D=3D 0); >=20 > to something like this: >=20 > if (atomic_fetchadd_long(&uip->ui_proccnt, diff) + diff > max) { > atomic_subtract_long(&uip->ui_proccnt, diff); > return (0); > } Ok, after implementing atomic_fetchadd_long() on amd64, we get additional 6% of performance improvement: x ./uidinfo_lockfree.txt (atomic_cmpset_long loop) + ./uidinfo_waitfree.txt (atomic_fetchadd_long) +--------------------------------------------------------------------------= ----+ | = +| | = +| |x xx xx = + ++| | |__MA___| = |AM| +--------------------------------------------------------------------------= ----+ N Min Max Median Avg Stddev x 5 1561566 1575987 1568964 1569767 5853.1399 + 5 1662362 1665936 1665810 1664881.8 1541.2693 Difference at 95.0% confidence 95114.8 +/- 6241.96 6.05917% +/- 0.397636% (Student's t, pooled s =3D 4279.88) --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --Li7ckgedzMh1NgdW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFGx3wdForvXbEpPzQRApSQAKDIUM4EV6lomKGgQouhx/RlehhVbwCgoTPf rG0yxVgxqJb74QUyxYDSZKY= =R+1E -----END PGP SIGNATURE----- --Li7ckgedzMh1NgdW--